[Debian-med-packaging] r11273 - trunk/packages/strap/trunk/debian

[Andreas Tille]

Hi Christoph,

thanks for your commits.  I'd like to add some comments:

On Thu, Jun 07, 2012 at 09:24:44PM +0000, Christoph Gille wrote:
> 
> Modified: trunk/packages/strap/trunk/debian/control
> ===================================================================
> --- trunk/packages/strap/trunk/debian/control	2012-06-07 19:57:38 UTC (rev 11272)
> +++ trunk/packages/strap/trunk/debian/control	2012-06-07 21:24:44 UTC (rev 11273)
> @@ -15,19 +15,19 @@
> +Description: Strap is a work-bench for proteins. It can be used to
> + display, edit and compute multiple sequence alignments, structure
> + alignments and 3D-structure superpositions. It aids structure /

This is not a good description.  The good packaging practice docs say,
that the first line (the "Description:" field line) should read like this:

Example:
      Package: foo
      Description: bar to do baz
Reading:
      foo is bar to do baz

In your example it would read

      strap is Strap is a work-bench for proteins. It can be used to

Considering this there are two mistakes:

   1. Repeated package name in the beginning
   2. It is no real short desrciption but rather the start of a text

I'd recommend to change it like this:

  Description: <some more detail??> work-bench for proteins
   Strap can be used to ...



> Modified: trunk/packages/strap/trunk/debian/rules
> ===================================================================
> --- trunk/packages/strap/trunk/debian/rules	2012-06-07 19:57:38 UTC (rev 11272)
> +++ trunk/packages/strap/trunk/debian/rules	2012-06-07 21:24:44 UTC (rev 11273)
> @@ -7,4 +7,11 @@
>  %:
>  	dh $@
>  
> +override_dh_auto_build:
> +	# Only two small sty files of the huge package texlive-latex-extra are required in Strap
> +	# Include these two files such that texlive-latex-extra  can be ommitted
> +	mkdir -p usr/lib/strap
> +	cp /usr/share/texmf-texlive/tex/latex/texshade/texshade.sty  usr/lib/strap
> +	cp /usr/share/texmf-texlive/tex/latex/vmargin/vmargin.sty usr/lib/strap	

This does not work.

   1. Most probably you want to do

     override_dh_auto_build:
		dh_auto_build
		# ... <your stuff>

      Rationale: As far as I can see you want to *add* something to the
      usual job dh_auto_build would do.  In your case you are *replacing*
      what dh_auto_build would do by your own stuff

   2. Your copied files will not end up in the package.  There are two
      options:

       a) mkdir -p $(CURDIR)/debian/tmp/usr/lib/strap
          cp /usr/share/texmf-texlive/tex/latex/texshade/texshade.sty  $(CURDIR)/debian/tmp/usr/lib/strap

          This moves files to debian/tmp first where it can be fetched by
          dh_install afterwards.

       b) in preambel do:
          pkg:=<target-package-name>

          in override do:

          mkdir -p $(CURDIR)/debian/$(pkg)/usr/lib/strap
          cp /usr/share/texmf-texlive/tex/latex/texshade/texshade.sty  $(CURDIR)/debian/$(pkg)/usr/lib/strap

          which moves the files right into place.
  
Hope this helps

      Andreas. 

-- 
http://fam-tille.de