[Debian-med-packaging] Bug#667939: last-align: Hardening flags missing

[Andreas Tille]

Hi Martin,

On Mon, May 07, 2012 at 05:50:26PM +0900, Martin Frith wrote:
> I used part of your patch in LASTv199.  (I didn't include the "+=" changes,
> because I think the purpose of those flag variables is to let you override
> them if you want to.  You might consider including "-O3" in your override.)

We can deal with your decision but usually we do not really want to
override but just add additional flags (like for hardening).  The thing is
that you as the author have choosen a set of flags on purpose.  If we
blindly override these we might not gain the same optimisation / whatever.
For the moment I worked around this that I used a 1:1 copy of your flags
in src/makefile and added the hardening flags.  The problem is if you might
change some options in future versions I might miss this change.  So for now
it is fine but the "+=" solution seems to be the better one.
 
> By the way, in your "rules" file, I think "clean" is no longer needed (now
> in the upstream makefile), nor is "--directory src" (there is now a
> top-level makefile).

Thanks for the hints and the extra comfort of the top-level makefile
which is used now.

> Please let me know if I misunderstood something.

No real misunderstanding - as I said we can live with this for now.

Thanks for your support

      Andreas.

-- 
http://fam-tille.de