[Debian-med-packaging] Please use comments in your commits [Was: r11062 - trunk/packages/strap/trunk/debian]

[Andreas Tille]

Hi Christoph,

thanks for your commits to the strap package.  As I wrote yesterday
it would really help if you would add some comment about the changes
either using

    svn commit -m "purpose of the commit"

or

    svn commit

and add the comment in the $EDITOR you are using.  Otherwise we can not
understand your intention.  For instance below is another commit I do
not understand without comment.  For me this postrm looks pretty useless
because it is debhelpers job to care for the menu code and you should
definitely not fiddle around with things like this except if something
is not working as expected.  In any case a postrm script should end
with

#DEBHELPER#
exit 0

(and may be this is the problem because you previousely injected a
totally empty postrm which prevents debhelper from injecting its code.
Please have a look into Developers Reference[1] the new maintainers
guide[2] and in this specific case probably the debhelper man page[3].

In short: If you would be more verbose about the motivation of your
change we could more easily help you to avoid misunderstandings.

Kind regards

        Andreas.

[1] http://www.debian.org/doc/manuals/developers-reference/
[2] http://www.debian.org/doc/manuals/maint-guide/
[3] http://man.he.net/man7/debhelper

----- Forwarded message from Christoph Gille <christophgil-guest at alioth.debian.org> -----

Date: Mon, 28 May 2012 22:25:11 +0000
From: Christoph Gille <christophgil-guest at alioth.debian.org>
To: debian-med-commit at lists.alioth.debian.org
Subject: r11062 - trunk/packages/strap/trunk/debian

Author: christophgil-guest
Date: 2012-05-28 22:25:10 +0000 (Mon, 28 May 2012)
New Revision: 11062

Modified:
   trunk/packages/strap/trunk/debian/strap.postrm
Log:


Modified: trunk/packages/strap/trunk/debian/strap.postrm
===================================================================
--- trunk/packages/strap/trunk/debian/strap.postrm	2012-05-28 22:19:32 UTC (rev 11061)
+++ trunk/packages/strap/trunk/debian/strap.postrm	2012-05-28 22:25:10 UTC (rev 11062)
@@ -1,2 +1,3 @@
 #!/bin/sh
-#xxxxxxxxxxxxxxxxx
+
+if [ -x "`which update-menus 2>/dev/null`" ]; then update-menus ; fi


_______________________________________________
debian-med-commit mailing list
debian-med-commit at lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-med-commit


----- End forwarded message -----

-- 
http://fam-tille.de