[Debian-med-packaging] r12208 - in trunk/packages/libsbml/trunk/debian: . lintian patches

[Andreas Tille]

On Thu, Sep 13, 2012 at 09:25:24PM +0000, Ivo Maintz wrote:
> Author: ivomaintz-guest
> Date: 2012-09-13 21:25:23 +0000 (Thu, 13 Sep 2012)
> New Revision: 12208
> 
> Added:
>    trunk/packages/libsbml/trunk/debian/libsbml5-java.symbols
>    trunk/packages/libsbml/trunk/debian/libsbml5.symbols

These are auto-genereated files that should *not* remain in debian/ dir
- please clean up before commiting.

>    trunk/packages/libsbml/trunk/debian/patches/hardening.patch
> Modified:
>    trunk/packages/libsbml/trunk/debian/README.source
>    trunk/packages/libsbml/trunk/debian/changelog
>    trunk/packages/libsbml/trunk/debian/compat
>    trunk/packages/libsbml/trunk/debian/control
>    trunk/packages/libsbml/trunk/debian/control.in
>    trunk/packages/libsbml/trunk/debian/lintian/libsbml5-perl
>    trunk/packages/libsbml/trunk/debian/patches/series
>    trunk/packages/libsbml/trunk/debian/patches/spelling.patch
>    trunk/packages/libsbml/trunk/debian/rules
>    trunk/packages/libsbml/trunk/debian/watch
> Log:
> please upload...

Hmmm, I know that when using SVN making atomar commits describing single
changes is sometimes hard if you are offline - but some more details
would help the potential sponsor definitely.

> overridden lintian-errors for some hardening options

OK

> Modified: trunk/packages/libsbml/trunk/debian/changelog
> ===================================================================
> --- trunk/packages/libsbml/trunk/debian/changelog	2012-09-13 05:03:29 UTC (rev 12207)
> +++ trunk/packages/libsbml/trunk/debian/changelog	2012-09-13 21:25:23 UTC (rev 12208)
> @@ -1,3 +1,11 @@
> +libsbml (5.6.0-1) UNRELEASED; urgency=low
> +
> +  [ Ivo Maintz ]
> +  * update from upstream
> +  * configured now with --enable-cpp-namespace
> +
> + -- Ivo Maintz <ivo at maintz.de>  Thu, 06 Sep 2012 09:21:33 +0200

That's also a bit less information considering those massive changes -
please be more verbose.

> Modified: trunk/packages/libsbml/trunk/debian/control
> ===================================================================
> --- trunk/packages/libsbml/trunk/debian/control	2012-09-13 05:03:29 UTC (rev 12207)
> +++ trunk/packages/libsbml/trunk/debian/control	2012-09-13 21:25:23 UTC (rev 12208)
>  Section: science
>  Homepage: http://www.sbml.org/
>  Vcs-Browser: http://svn.debian.org/wsvn/debian-med/trunk/packages/libsbml/trunk/
> -Vcs-Svn: svn://svn.debian.org/debian-med/trunk/packages/libsbml
> +Vcs-Svn: svn://svn.debian.org/svn/debian-med/trunk/packages/libsbml

That's wrong (I removed the 'svn/' string).  Possibly you are
auto-creating debian/control from debian/control.in and this reverted my
previous automatic change - I fixed it also in control.in.
  
> Added: trunk/packages/libsbml/trunk/debian/patches/hardening.patch
> ===================================================================
> --- trunk/packages/libsbml/trunk/debian/patches/hardening.patch	                        (rev 0)
> +++ trunk/packages/libsbml/trunk/debian/patches/hardening.patch	2012-09-13 21:25:23 UTC (rev 12208)
> @@ -0,0 +1,95 @@
> +Description: hardening
> +
> + .
> + libsbml (5.6.0-1) UNRELEASED; urgency=low
> + .
> +   * [ Ivo Maintz ]
> +     update from upstream
> +Author: Ivo Maintz <ivo at maintz.de>
> +
> +---
> +The information above should follow the Patch Tagging Guidelines, please
> +checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
> +are templates for supplementary fields that you might want to add:

Please follow this advise and once done you can remove the hint.

> Modified: trunk/packages/libsbml/trunk/debian/rules
> ===================================================================
> --- trunk/packages/libsbml/trunk/debian/rules	2012-09-13 05:03:29 UTC (rev 12207)
> +++ trunk/packages/libsbml/trunk/debian/rules	2012-09-13 21:25:23 UTC (rev 12208)
> @@ -5,7 +5,15 @@
>  # Uncomment this to turn on verbose mode.
>  #export DH_VERBOSE=1
>  
> +# hardening
>  
> +CFLAGS = `dpkg-buildflags --get CFLAGS`
> +CFLAGS += -Wall
> +CXXFLAGS = `dpkg-buildflags --get CXXFLAGS`
> +CXXFLAGS += -Wall
> +LDFLAGS = `dpkg-buildflags --get LDFLAGS`
> +CPPFLAGS = `dpkg-buildflags --get CPPFLAGS`

Just a hint:  If you are using debhelper 9 you can safe *a* *real* *lot*
of typing making the debian/rules file *way* *more* *easy* and leave out
all the stuff above completely if you would switch to short dh notation.
While it is your choice I *strongly* recommend switching.  The time to
"learn" is very well invested (because there is so view to learn and
very much to win.

> clean:
> ...
> +	rm -rf .pc .debs config docs examples macosx src config.guess config.sub

I guess a single

	 dh $@ --with autoreconf

would solve a real lot of the problems your are trying to deal with - we
have several examples for this in SVN - a random one would be
exonerate.  More can be found using

    $ grep -l autoreconf trunk/packages/*/trunk/debian/rules

>  	dh_clean
> +	tar xzf ../libsbml_$(version).orig.tar.gz -C ../

Sorry, this is plain wrong and I hope nobody will sponsor this!

You should *not* create the orig.tar.gz file inside the clean target.
If you do not know why feel free to ask for reasons.

Please try to be more verbose on the mailing list.  I found several
issues in your packing but not a single request for help on the list
where you easily could have found kind advise (for instance to use
autoreconf) to solve problems quite elegantly.

Kind regards and thanks for your work on libsbml anyway

     Andreas.

PS: I might be more or less offlinish from mid off next week until
    first week of October - hopefully others might step in for help /
    sponsering if needed.

-- 
http://fam-tille.de