[Debian-med-packaging] r12212 - trunk/packages/libsbml/trunk/debian

[Andreas Tille]

Hi Steffen,

On Fri, Sep 14, 2012 at 08:26:22PM +0000, Steffen Möller wrote:
> 
> Modified: trunk/packages/libsbml/trunk/debian/rules
> ===================================================================
> --- trunk/packages/libsbml/trunk/debian/rules	2012-09-14 13:57:12 UTC (rev 12211)
> +++ trunk/packages/libsbml/trunk/debian/rules	2012-09-14 20:26:22 UTC (rev 12212)
> @@ -105,7 +105,7 @@
>  	### verx ugly ###
>  	rm -rf .pc .debs config docs examples macosx src config.guess config.sub
>  	dh_clean
> -	tar xzf ../libsbml_$(version).orig.tar.gz -C ../
> +	tar --no-same-owner -xzf ../libsbml_$(version).orig.tar.gz -C ../

I guess you consider that --no-same-owner is fixing my remark about
changing md5 sum of tarball but it remains totally wrong and you should
definitely not have uploaded the package.  You should never ever create
the orig.tar.gz in a clean target and I wished that this knowledge is
spread between all team members instead of uploading inacceptable dirty
hacks.  I'm offering explicite mentoring (MoM) to train people about
proper packaging and I spended some time to analyse the problems of the
package and it could be fixed in about a weeks time easily (I do not
think that I need to express explicitely that I would have helped
working on this).  I see no point in pushing hard for an upload with
obvious serious problems.

Kind regards

        Andreas.

-- 
http://fam-tille.de