[Debian-med-packaging] r12915 - in trunk/packages/fis-gtm/trunk/debian: . patches

[Andreas Tille]

Hi Amul,

thanks for your work on the fis-gtm package.

On Tue, Feb 05, 2013 at 07:45:48PM +0000, Amul Shah wrote:
> 
> Modified: trunk/packages/fis-gtm/trunk/debian/changelog
> ===================================================================
> --- trunk/packages/fis-gtm/trunk/debian/changelog	2013-02-05 18:13:50 UTC (rev 12914)
> +++ trunk/packages/fis-gtm/trunk/debian/changelog	2013-02-05 19:45:48 UTC (rev 12915)
> @@ -1,3 +1,12 @@
> +fis-gtm (6.0.001) UNRELEASED; urgency=low
> +
> +  [ Amul Shah ]
> +  * Change target release version V6.0.001
> +  * Update patches to match the new sources.
> +    Special thanks to Brad King for reissuing them
> +
> + -- Amul Shah <amul.shah at fisglobal.com>  Fri, 25 Jan 2013 23:13:11 -0500
> +
>  fis-gtm (5.5-000+git109-g57f2d89-1) UNRELEASED; urgency=low
>  
>    [ Luis Ibanez ]

It is OK to create another paragraph in debian/changelog.  I just want
to make you aware that it is the usual case to have only one entry in a
package that is new to the Debian package pool.  I'd recommend to keep
on maintaining the changelog for the moment but before the final upload
we might strip this down to  "Inital upload" (as it is usual for new
Debian packages.)
 
> Modified: trunk/packages/fis-gtm/trunk/debian/compat
> ===================================================================
> --- trunk/packages/fis-gtm/trunk/debian/compat	2013-02-05 18:13:50 UTC (rev 12914)
> +++ trunk/packages/fis-gtm/trunk/debian/compat	2013-02-05 19:45:48 UTC (rev 12915)
> @@ -1 +1 @@
> -9
> +8
> 
> Modified: trunk/packages/fis-gtm/trunk/debian/control
> ===================================================================
> --- trunk/packages/fis-gtm/trunk/debian/control	2013-02-05 18:13:50 UTC (rev 12914)
> +++ trunk/packages/fis-gtm/trunk/debian/control	2013-02-05 19:45:48 UTC (rev 12915)
> @@ -1,14 +1,15 @@
>  Source: fis-gtm
>  Section: database
>  Priority: extra
> -Build-Depends: debhelper (>= 9),
> +Build-Depends: debhelper (>= 8.0.0),

Could you please give some reasons why you decreased the debhelper
compatibility level?  There might be good reasons to do this but it
would be reasonable to mention these arguments to prevent that other
team members start playing pingpong unintetionally with you.

> -Maintainer: Debian Med Packaging Team <debian-med-packaging at lists.alioth.debian.org>
> +Maintainer: Amul Shah <Amul.Shah at fisglobal.com>
> +			Debian Med Packaging Team <debian-med-packaging at lists.alioth.debian.org>
>  DM-Upload-Allowed: yes
>  Uploaders: Andreas Tille <tille at debian.org>,
>             Thorsten Alteholz <debian at alteholz.de>,

This change is wrong - please add your name to Uploaders and not to
Maintainer.

Kind regards and thanks again for your work on this

       Andreas.

-- 
http://fam-tille.de