[Debian-med-packaging] Bug#700088: Bug#700088: boxshade: fails finding the alignment file

Charles Plessy plessy at debian.org
Sat Feb 9 03:09:55 UTC 2013


severity 700088 serious
thanks

Le Fri, Feb 08, 2013 at 03:59:54PM +0100, Giorgio Maccari a écrit :
> 
> boxshade seems to have some problem to read the path of files from stdin, in particular it mantains the trailing newline character as part of the name, as a results the application is unusable.
> Please considre the following patch as a possible fix (or workaround) for the problem.
> 
> -------------------PATCH-------------------------------
> --- boxshade-3.3.1.old/bx_read.c    2013-02-08 15:20:14.000000000 +0100
> +++ boxshade-3.3.1.new/bx_read.c    2013-02-08 15:10:52.590377053 +0100
> @@ -4,7 +4,9 @@
> 
>  char *Gets(char *s, size_t length) {
>    fflush(stdout);
> -  return fgets(s,length,stdin);
> +  fgets(s,length,stdin);
> +  strtok(s, "\n");
> +  return s;
>  }
> 
>  /*
> -----------------------------------------------------

Dear Giorgio,

thank you very much for your report.  Your patch works well, and I hope
that we can use it to correct the package in Wheezy as I think that the
inability to use boxshade interactively strongly reduces its usefuleness.

I also posted your patch on SourceForge, in case it can be usefult outside
Debian.  https://sourceforge.net/tracker/?func=detail&aid=3603900&group_id=176110&atid=875933

By the way, I noticed that, while boxshade proposes a default choice for
the many formatting options, simply hitting enter does not select it.
Do you think that it is a bug that you can fix ?

In the meantime, I have uploaded a corrected package where only your patch
has been added.  I attached the debdiff and the build log.

Have a nice day,

Charles

-- 
Charles Plessy
Debian Med packaging team,
http://www.debian.org/devel/debian-med
Tsurumi, Kanagawa, Japan
-------------- next part --------------
diff -Nru boxshade-3.3.1/debian/changelog boxshade-3.3.1/debian/changelog
--- boxshade-3.3.1/debian/changelog	2012-07-31 18:25:01.000000000 +0900
+++ boxshade-3.3.1/debian/changelog	2013-02-09 11:57:39.000000000 +0900
@@ -1,3 +1,10 @@
+boxshade (3.3.1-7+wheezy1) unstable; urgency=low
+
+  * debian/patches/remove-newlines.patch: restores interactive use.
+    Thanks: Giorgio Maccari. Closes: #700088.
+
+ -- Charles Plessy <plessy at debian.org>  Sat, 09 Feb 2013 11:57:21 +0900
+
 boxshade (3.3.1-7) unstable; urgency=low
 
   * debian/install: Make sure boxshade executable will be installed
diff -Nru boxshade-3.3.1/debian/patches/remove-newlines.patch boxshade-3.3.1/debian/patches/remove-newlines.patch
--- boxshade-3.3.1/debian/patches/remove-newlines.patch	1970-01-01 09:00:00.000000000 +0900
+++ boxshade-3.3.1/debian/patches/remove-newlines.patch	2013-02-09 11:52:34.000000000 +0900
@@ -0,0 +1,18 @@
+Description: Removes trailing newlines from standard inputs.
+Author: Giorgio Maccari <giorgio.maccari at gmail.com>
+Bug-Debian: http://bugs.debian.org/700088
+Forwarded: https://sourceforge.net/tracker/?func=detail&aid=3603900&group_id=176110&atid=875933
+--- boxshade-3.3.1.old/bx_read.c    2013-02-08 15:20:14.000000000 +0100
++++ boxshade-3.3.1.new/bx_read.c    2013-02-08 15:10:52.590377053 +0100
+@@ -4,7 +4,9 @@
+
+ char *Gets(char *s, size_t length) {
+   fflush(stdout);
+-  return fgets(s,length,stdin);
++  fgets(s,length,stdin);
++  strtok(s, "\n");
++  return s;
+ }
+
+ /*
+
diff -Nru boxshade-3.3.1/debian/patches/series boxshade-3.3.1/debian/patches/series
--- boxshade-3.3.1/debian/patches/series	2008-11-17 15:37:03.000000000 +0900
+++ boxshade-3.3.1/debian/patches/series	2013-02-09 11:52:39.000000000 +0900
@@ -1,2 +1,3 @@
 10_makefile.unx.patch
 kickOutGets.patch
+remove-newlines.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: boxshade_3.3.1-7+wheezy1_amd64.build.xz
Type: application/octet-stream
Size: 6852 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20130209/f1533014/attachment.obj>


More information about the Debian-med-packaging mailing list