[Debian-med-packaging] Bug#703076: Missing argument in calls to amitk_color_table_menu_new

[Michael Tautschnig]

Package: amide
Version: 1.0.1-1
Usertags: goto-cc

Building and type-checking the linked results using our research compiler
infrastructure showed the following wrong uses of amitk_color_table_menu_new:

./src/amitk_threshold.c:    threshold->color_table_menu[i_view_mode] = amitk_color_table_menu_new();
./src/ui_preferences_dialog.c:    menu = amitk_color_table_menu_new();
./src/ui_render_dialog.c:    menu = amitk_color_table_menu_new();

This conflicts with the actual definition of amitk_color_table_menu_new:

./src/amitk_color_table_menu.c:GtkWidget * amitk_color_table_menu_new(AmitkColorTable color_table) {

The result will necessarily cause a stack underflow, with entirely undefined
consequences (for any application with elevated privileges this is a possibly
security issue).

Best,
Michael

PS.: It may be wise to also adjust the declaration of
amitk_color_table_menu_new:

./src/amitk_color_table_menu.h:GtkWidget*    amitk_color_table_menu_new               ();

(but this is actually entirely covered by the C standard and not necessarily a
bug - it just stops the compiler from producing proper diagnostics).

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20130314/625c5fc7/attachment.pgp>