[Debian-med-packaging] Bug#730636: Bug#730636: Do not always set CMAKE_BUILD_TYPE to Release

[Dmitrijs Ledkovs]

On 28 November 2013 10:34, Jörg Riesmeier <debian at riesmeier.de> wrote:
>> dcmtk package is trying to set CMAKE_BUILD_TYPE to Release instead of
>> letting the user decide what best to use.
>> It would be nice to have an option to override this default, as Debian
>> requires specific compilation flags, which conflicts with what
>> CMAKE_BUILD_TYPE:Release sets.
>
>> I am attaching current patch.
>
> Your patch removes a patch that was contributed only recently by Jean-
> Christophe Fillion-Robin from Kitware (i.e. the publisher of CMake):
>
>   http://git.dcmtk.org/web?p=dcmtk.git;a=commit;h=1beff6732f65c4e364acbd7d4643a02ed02f82ee
>
> Also, as far as I can see, the "IF(NOT CMAKE_BUILD_TYPE AND NOT
> CMAKE_CONFIGURATION_TYPES)" statement should make sure that the build type is
> only set if it was undefined.
>
> Don't you agree?
>

No. In Debian, we want environment CFLAGS/CXXFLAGS etc to be honered
such that distribution default options are used (optimised with debug
symbols), hardenning-wrapper / buildflags.mk are applied, and if users
choose to rebuild with DEB_BUILD_OPTIONS (e.g. nostrip, etc) those are
also honred. In cmake buildtypes by default that matches to _not_
specifying any buildtype, such that cmake falls back to "default"
build type, in which case environment flags are used. There is no way
for upstream to guess/pick all of those combinations of options that
by policy all packges in Debian should support.

Regards,

Dmitrijs.