[Debian-med-packaging] Bug#772305: mafft: bashism in /bin/sh script

[Andreas Tille]

Hi Raphael,

thanks for your QA effort to fix bashisms.

On Sat, Dec 06, 2014 at 02:15:39PM +0100, Raphael Geissert wrote:
> I've ran checkbashisms (from the 'devscripts' package) over the whole
> archive and I found that your package has a /bin/sh script that uses a
> "bashism".
> 
> checkbashisms' output:
> > possible bashism in ./usr/lib/mafft/bin/mafft line 1768 (unsafe echo with
> > backslash):
> >				  echo "Warning: Sequence homologs of the
> > structures given with the --pdbfilelist option cannot be collected.\n"
> > 1>>"$progressfile"

>From what I can see this claimed bashism does not harm here at all.  The
author intended to add a blank line after the warning and to my test
this *only* works in dash while bash verbosely prints \n in the output.

The fix is probably replacing the "\n" by an additional "echo" statement
but I'm tempted to ignore this since for the program t finally does not
matter whether the empty line is output or not. 

The only reason to fix this bug would be to silence your sentinel in the
future.

What do you think?

Kind regards

     Andreas.

-- 
http://fam-tille.de