[Debian-med-packaging] Bug#738962: python-csb: More issues with the tests
Dmitry Shachnev
mitya57 at gmail.com
Fri Feb 14 10:18:58 UTC 2014
Source: python-csb
Version: 1.2.2+dfsg-2
Severity: important
Dear Maintainer,
I have tried to fix the python-csb autopkgtest and noticed the following things:
1) python-csb should depend on python-numpy and python-scipy (and python3-csb
should depend on python3-numpy and python3-scipy). These dependencies are
specified in REQUIRES field in setup.py and, as I understand, the package
is mostly useless without these dependencies. The tests also need numpy
to succeed.
2) In debian/tests/build, Makefile-style variables are used. I think that was
blindly copied from debian/rules, and not really needed.
Also, you use python instead of $python, so in fact the test is ran
three times for python2.7.
I would write the command like this:
for py in $(pyversions -i) $(py3versions -i); do
PYTHONWARNINGS=d $py test/app.py --generated-resources /tmp --verbosity 2
done
Note that I also increased verbosity to get the more understandable output
in case of failures.
3) One of the tests fails (at least with Python 2.7):
FAIL: testWHAM (usr/lib/python2-7/dist-packages/csb/test/cases/statmech/wham.TestWHAM)
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/csb/test/cases/statmech/wham.py", line 80, in testWHAM
self.log_z, delta=0.5)
File "/usr/lib/python2.7/dist-packages/csb/test/__init__.py", line 415, in assertAlmostEqual
raise self.failureException(msg)
AssertionError: nan != -14.7726232844 within 0.5 delta
4) The tests failures are ignored. When the test fails for python2.7, the next
tests are run.
5) Some test is printed into stderr, for example the deprecation warnings and
names of the tests. Autopkgtest considers that as a failure by default, to
allow stderr you need to add this line to debian/tests/control:
Restrictions: allow-stderr
Please contact me or debian-python at lists.debian.org if you have any questions.
Hope my investigation helps,
--
Dmitry Shachnev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20140214/7a884776/attachment-0001.sig>
More information about the Debian-med-packaging
mailing list