[Debian-med-packaging] python-pysam_0.7.5-1_amd64.changes REJECTED
Andreas Tille
andreas at fam-tille.de
Tue Feb 18 19:20:06 UTC 2014
Hi Thorsten,
thanks for your thorough review.
On Tue, Feb 18, 2014 at 07:00:06PM +0000, Thorsten Alteholz wrote:
>
> Hi Andreas,
>
> unfortunately I have to reject your package.
>
> debian/copyright is almost perfect, but you missed the entry for
> pysam-0.7.5/samtools/misc/md5.*
FIxed.
> Upstream-Contact: seems to be not Heng Li but Andreas Heger. Does he
> really work at GLR so that the entry for "Files: *" is correct?
TTBOMK the Files: * is correct. However, I fixed the Upstream-Contact.
> Meanwhile the pysam repository is no longer at Google but at GitHub.
I have seen the link on the code.google.com page but I have not (yet)
found any new tagges release on Github. We will try to observe this for
the next releases.
> Anyway, maybe you could also simplify things by combining all entries
> for Heng Li to only one big entry (btw. he has the copyright for more files).
Fixed.
> Code duplication is bad and against Debian Policy 4.13. Nevertheless
> there seems to be a reason for it, so it should be documented somewhere
> in the package and not only appear on the mailling list. It would be
> nice if you could poke the samtools upstream to introduce a library.
> Maybe he also likes cake ...
Yes, there should be some better documentation about this and nagging
upstream is something we try to approach as well. However, I personally
considered it more convincing to show them: Hey, we try to do something
for you, lets try to do it the "right way" (tm) the next time. I hope
this will work. For the moment I need this package urgently for at
least two other packages so I decided to go for it that way. I hope
this is acceptable.
Kind regards
Andreas.
--
http://fam-tille.de
More information about the Debian-med-packaging
mailing list