[Debian-med-packaging] Bug#751586: python-biopython: tests are run with HOME=/tmp

Jakub Wilk jwilk at debian.org
Sat Jun 14 21:00:16 UTC 2014


* Andreas Tille <tille at debian.org>, 2014-06-14, 21:50:
>[1]  http://anonscm.debian.org/viewvc/debian-med?view=revision&revision=17161

From the security POV it's okay, but there's a subtle bug that will 
prevent the temporary from being removed.

Note that “rm -rf $$tmpdir” is not a part of of the --test-args 
argument, but a separate command. So it won't be executed in the same 
shell that set the variable.

Another bug is that errors from mktemp are ignored. Actually the whole 
sequence in --test-args needs a “set -e”.

So, since using mktemp in debian/rules is rather error prone, how about 
this (untested) patch?

-- 
Jakub Wilk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 751586.diff
Type: text/x-diff
Size: 1261 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20140614/f82c60be/attachment.diff>


More information about the Debian-med-packaging mailing list