[Debian-med-packaging] Bug#740705: Please incorportate ubuntu patches

[Gianfranco Costamagna]

Package: insighttoolkit
Version:  3.20.1+git20120521-4
Severity: wishlist
Tags: patch

Dear Maintainer,

The ubuntu insidhttoolkit package has some patches that would be nice to have included in (maybe) the next upload, or at least discussed here.

Since the "tiff-4/5" patch has been dropped in debian, in favor of the embedded copy I suggest to include/drop the other delta from ubuntu.

The patch is snan-sanity.patch

and this is the content:


Index: insighttoolkit-3.20.1+git20120521/Utilities/NrrdIO/sane.c =================================================================== --- insighttoolkit-3.20.1+git20120521.orig/Utilities/NrrdIO/sane.c	2012-09-11 17:25:06.000000000 +0000 +++ insighttoolkit-3.20.1+git20120521/Utilities/NrrdIO/sane.c	2012-09-11 17:39:19.196189762 +0000 @@ -115,7 +115,11 @@ ( defined(__GNUC__) && (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__  >= 7 ))) /* don't compare airFP_SNAN */ #else -         && airFP_SNAN == airFPClass_f(AIR_SNAN)  +         /* we don't bother checking for  +            airFP_SNAN == airFPClass_f(AIR_SNAN) because +            the signal-ness of the NaN is not preserved in +            float conversion */ +         /* && airFP_SNAN == airFPClass_f(AIR_SNAN) */ #endif && airFP_QNAN == airFPClass_d(AIR_NAN) && airFP_QNAN == airFPClass_d(AIR_QNAN) )) {


and the rationale for including it (quoting the ubuntu changelog)
insighttoolkit (3.20.1+git20120521-1ubuntu3) quantal; urgency=low * debian/patches/snan-sanity.patch: - In sanity checks done by the nrrd utility code, don't bother testing signal NaN clases, because GCC does not guarantee to preserve signal-ness across float conversions. This was contributing to a FTBFS for plastimatch. -- Michael Terry <mterry at ubuntu.com> Wed, 25 Jul 2012 14:08:00 -0400

thanks for reading,

Gianfranco