[Debian-med-packaging] Bug#742579: hhsuite: FTBFS with libpng 1.6

[Nobuhiro Iwamatsu]

Source:  hhsuite
Version: 2.0.16-1
User: libpng at packages.debian.org
Usertags: libpng15-transition

Hi,

libpng maintainers have a plan transition of libpng16[0].

libpng16 is already installed in experimental, and we are re-building
the package depending on libpng16.
As a result, we checked that your package was FTBFS.
Would you check also in your environment?
And if you could confirm problem, could you fix this?
----
In file included from hhalign.C:105:0:
pngwriter.cc: In member function 'void pngwriter::close()':
pngwriter.cc:1001:23: warning: 'const char*
png_convert_to_rfc1123(png_structrp, png_const_timep)' is deprecated
(declared at /usr/include/png.h:1146) [-Wdeprecated-declarations]
    text_ptr[3].text = png_convert_to_rfc1123(png_ptr, &mod_time);
                       ^
pngwriter.cc:1001:64: warning: 'const char*
png_convert_to_rfc1123(png_structrp, png_const_timep)' is deprecated
(declared at /usr/include/png.h:1146) [-Wdeprecated-declarations]
    text_ptr[3].text = png_convert_to_rfc1123(png_ptr, &mod_time);
                                                                ^
pngwriter.cc:1001:64: error: invalid conversion from 'png_const_charp
{aka const char*}' to 'png_charp {aka char*}' [-fpermissive]
hhblits.C: In function 'int main(int, char**)':
hhblits.C:2140:25: warning: ISO C++ does not support variable-length
array types [-Wvla]
   format = new(int[bins]);
                         ^
hhblits.C:2240:58: warning: ISO C++ does not support variable-length
array types [-Wvla]
   dbfiles_new[ndb_new]=new(char[strlen(dbfiles_old[a])+1]);
                                                          ^
pngwriter.cc: In member function 'void pngwriter::readfromfile(char*)':
pngwriter.cc:1297:105: error: cannot convert 'long unsigned int*' to
'png_uint_32* {aka unsigned int*}' for argument '3' to 'png_uint_32
png_get_IHDR(png_const_structrp, png_const_inforp, png_uint_32*,
png_uint_32*, int*, int*, int*, int*, int*)'
    png_get_IHDR(png_ptr, info_ptr, &width, &height, &bit_depth,
&color_type, &interlace_type, NULL, NULL);

                                  ^
pngwriter.cc:1314:33: error: 'png_set_gray_1_2_4_to_8' was not
declared in this scope
  png_set_gray_1_2_4_to_8(png_ptr);  // Just an alias of the above.
                                 ^
pngwriter.cc:1345:103: error: cannot convert 'long unsigned int*' to
'png_uint_32* {aka unsigned int*}' for argument '3' to 'png_uint_32
png_get_IHDR(png_const_structrp, png_const_inforp, png_uint_32*,
png_uint_32*, int*, int*, int*, int*, int*)'
  png_get_IHDR(png_ptr, info_ptr, &width, &height, &bit_depth,
&color_type, &interlace_type, NULL, NULL);

                                ^
pngwriter.cc:1350:69: error: no matching function for call to
'pngwriter::read_png_image(FILE*&, png_struct*&, png_info*&, unsigned
char***, long unsigned int*, long unsigned int*)'
    if(!read_png_image(fp, png_ptr, info_ptr, &image, &width, &height))
                                                                     ^
pngwriter.cc:1350:69: note: candidate is:
In file included from hhalign.C:104:0:
pngwriter.h:119:8: note: int pngwriter::read_png_image(FILE*,
png_structp, png_infop, png_byte***, png_uint_32*, png_uint_32*)
    int read_png_image(FILE *fp, png_structp png_ptr, png_infop info_ptr,
        ^
pngwriter.h:119:8: note:   no known conversion for argument 5 from
'long unsigned int*' to 'png_uint_32* {aka unsigned int*}'
In file included from /usr/include/pngconf.h:72:0,
                 from /usr/include/png.h:456,
                 from pngwriter.h:49,
                 from hhalign.C:104:
pngwriter.cc: In member function 'int pngwriter::read_png_info(FILE*,
png_struct**, png_info**)':
pngwriter.cc:1533:25: error: invalid use of incomplete type
'png_struct {aka struct png_struct_def}'
    if (setjmp((*png_ptr)->jmpbuf)) /*(setjmp(png_jmpbuf(*png_ptr))
)*//////////////////////////////////////
                         ^
In file included from pngwriter.h:49:0,
                 from hhalign.C:104:
/usr/include/png.h:555:16: error: forward declaration of 'png_struct
{aka struct png_struct_def}'
 typedef struct png_struct_def png_struct;
                ^
hhalign.C: In function 'void ProcessArguments(int, char**)':
----

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6