[Debian-med-packaging] Bug#749136: jellyfish: FTBFS with clang instead of gcc

[Martin Steghöfer]

Hi all,

I can confirm that the build fails with clang 3.4 and that the patch 
sent by Alexander fixes the problem.

The most recent version of clang (3.5), however, compiles the package 
fine without any patches. This is because Clang has extended its 
detection of constant values and is now able to detect that the used 
size is a constant value, even if it's passed through a function.

In case you decide to patch the code anyway (after all it's non-standard 
language features that make it compile - GCC's support for VLAs and 
Clang's extended detection of constant values), there's an alternative 
patch attached to this message. I originally created it because I didn't 
realize that Alexander had already attached a patch (I'm sorry, 
Alexander, I didn't mean to disappreciate your work!). Now I decided to 
send it in anyway because it's an alternative way to fix the problem, 
one that's probably closer to the upstream authors' intention to 
allocate the space on the stack using a fixed-length array.

Btw. I noted that there has been a jellyfish 2 out there for quite some 
time now (almost a year). As they moved to github for the 2.x releases 
and the watch file is only targeting the old html page, maybe you missed 
it...

Cheers,
Martin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-compilation.patch
Type: text/x-diff
Size: 1756 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20141003/03ec811d/attachment.patch>