[Debian-med-packaging] Bug#804578: Does not build using dcmtk 3.6.1

[Andreas Tille]

Hi Gert,

switching to English and CC-ing the bug since the issue seems to be more
complicated.

In the old dcmtk package aeskulap has built perfectly.  In URL

    http://support.dcmtk.org/docs/ofcond_8h-source.html

there are "EC_Normal" as well as "ECC_Normal".

In libdcmtk2-dev from Jessie the string exists exactly one times:

/usr/include/dcmtk $ grep -R ECC_Normal
ofstd/ofcond.h:extern const OFConditionConst ECC_Normal;
ofstd/ofcond.h:  OFCondition(const OFConditionConst& base = ECC_Normal)


The EC_Normal mentioned by Gert occures way more:

/usr/include/dcmtk $ grep -R EC_Normal | grep -v ": *\*\+ "
dcmnet/cond.h:#define ASC_NORMAL                    EC_Normal
dcmnet/cond.h:#define DIMSE_NORMAL                  EC_Normal
ofstd/ofcond.h:extern const OFCondition EC_Normal;
dcmpstat/dvpsdef.h:if (result==EC_Normal)                                              \
dcmpstat/dvpsdef.h:if (result==EC_Normal)                                              \
dcmpstat/dvpsdef.h:if (writeresult==EC_Normal)                                         \
dcmpstat/dvpsdef.h:if (result==EC_Normal)                                              \
dcmpstat/dvpsdef.h:if (EC_Normal == dset.search((DcmTagKey &)a_name.getTag(), stack, ESM_fromHere, OFFalse)) \
dcmpstat/dvpsdef.h:if (EC_Normal == item->search((DcmTagKey &)a_name.getTag(), stack, ESM_fromHere, OFFalse)) \
dcmpstat/dvpsdef.h:if (rqDataset && (EC_Normal == rqDataset->search((DcmTagKey &)a_name.getTag(), stack, ESM_fromHere, OFFalse))) \
dcmpstat/dvpsdef.h:if (result==EC_Normal)                                              \
dcmdata/dctag.h:    /// current error code, EC_Normal if a valid VR for the tag is known
dcmdata/dcovlay.h:      return EC_Normal;
dcmdata/dcrledec.h:    if (compressedSize == 0) return EC_Normal;
dcmdata/dcrledec.h:      result = EC_Normal;
dcmdata/libi2d/i2dbmps.h:    return EC_Normal;
dcmsr/dsrtlist.h:            result = EC_Normal;
dcmsr/dsrtlist.h:            result = EC_Normal;
dcmsr/dsrtlist.h:                result = EC_Normal;
dcmsr/dsrtlist.h:            result = EC_Normal;
dcmsr/dsrtypes.h:                                    const OFCondition &searchCond = EC_Normal,


What is astonishing is that at no point EC*_Normal gets a real
value.  I commited a patch replacing ECC_Normal by EC_Normal but
even than I'm running into build errors:

                 from poolservers.cpp:30:
/usr/include/dcmtk/config/osconfig.h:796:0: note: this is the location of the previous definition
 #define PACKAGE_NAME "dcmtk"
 ^
In file included from ../gettext.h:22:0,
                 from poolservers.cpp:31:
../config.h:96:0: warning: "PACKAGE_VERSION" redefined
 #define PACKAGE_VERSION ""
 ^
In file included from poolassociation.h:33:0,
                 from poolservers.cpp:30:
/usr/include/dcmtk/config/osconfig.h:814:0: note: this is the location of the previous definition
 #define PACKAGE_VERSION "3.6.1"
 ^
In file included from imagepool.h:32:0,
                 from poolservers.cpp:29:
poolinstance.h:63:2: warning: 'typedef' was ignored in this declaration
  };
  ^
In file included from poolservers.cpp:30:0:
poolassociation.h:59:2: error: 'CONDITION' does not name a type
  CONDITION Connect(Network* network, int lossy = 0);
  ^
poolassociation.h:66:2: error: 'CONDITION' does not name a type
  CONDITION Drop(CONDITION cond=DIMSE_NORMAL);
  ^
poolassociation.h:71:10: error: 'CONDITION' does not name a type
  virtual CONDITION SendObject(DcmDataset* dataset);
          ^
poolassociation.h:76:10: error: 'CONDITION' does not name a type
  virtual CONDITION SendObject(DcmFileFormat* dcmff);
          ^

Any idea?

Kind regards

      Andreas.




On Tue, Dec 01, 2015 at 02:58:07PM +0100, Gert Wollny wrote:
> 
> Hallo Andreas, 
> 
> dicomdir.cpp:46:35: error: 'ECC_Normal' was not declared in this
> > scope
> >          if ( (ret=dir.error()) != ECC_Normal ) {
> > 
> 
> In dicomscope have ich nur "EC_Normal" gesehen, aber nicht "ECC_Normal"
> 
> Ciao, 
> Gert 
> 

-- 
http://fam-tille.de