[Debian-med-packaging] Bug#631249: Bug#631249: Current t-coffee builds on all architectures

[Andreas Tille]

Hi Charles,

On Tue, Dec 22, 2015 at 06:36:30PM +0900, Charles Plessy wrote:
> Le Tue, Dec 22, 2015 at 09:50:02AM +0100, Andreas Tille a écrit :
> > 
> > according to
> > 
> >    https://buildd.debian.org/status/package.php?p=t-coffee
> > 
> > the current t-coffee builds on all architectures.  Can we close
> > this bug now?
> 
> Hi Andreas,
> 
> the main problem was that t-coffee hangs forever on the armel architecture.
> Whether the build completed or not just reflected whether testing the binary
> was part of the build or not.  In 2012, I disabled this test, but unfortunately
> the commit message (revision 9694) does not explain well why I did this.
> Probably because the way the test was implemented was wasting ARM buildd time.

So how exactly does

$ svn diff -r 9693:9694
Index: debian/control
===================================================================
--- debian/control      (Revision 9693)
+++ debian/control      (Revision 9694)
@@ -6,7 +6,7 @@
 Uploaders: Steffen Moeller <moeller at debian.org>,
  Charles Plessy <plessy at debian.org>,
  Andreas Tille <tille at debian.org>
-Build-Depends: debhelper (>= 8), cdbs, quilt
+Build-Depends: debhelper (>= 8), cdbs, quilt, gfortran
 Standards-Version: 3.9.2
 Vcs-Browser: http://svn.debian.org/wsvn/debian-med/trunk/packages/t-coffee/trunk/
 Vcs-Svn: svn://svn.debian.org/debian-med/trunk/packages/t-coffee/trunk/
Index: debian/changelog
===================================================================
--- debian/changelog    (Revision 9693)
+++ debian/changelog    (Revision 9694)
@@ -1,6 +1,7 @@
 t-coffee (9.02.r1228-1) UNRELEASED; urgency=low
 
   * New upstream release (Closes: #649263).
+  * Build new Fortran tool (debian/rules, debian/contol).
 
  -- Charles Plessy <plessy at debian.org>  Fri, 02 Dec 2011 21:28:09 +0900
 
Index: debian/rules
===================================================================
--- debian/rules        (Revision 9693)
+++ debian/rules        (Revision 9694)
@@ -9,7 +9,9 @@
 
 DEB_COMPRESS_EXCLUDE = .doc
 
-DEB_MAKE_BUILD_TARGET  = -C t_coffee_source -i USER_BIN=../bin/ all
+FCC = gfortran $(shell dpkg-buildflags --get FFLAGS)
+
+DEB_MAKE_BUILD_TARGET  = -C t_coffee_source -i USER_BIN=../bin/ FCC="$(FCC)" all
 DEB_MAKE_CHECK_TARGET   = -f debian/rules check
 
 check:

prevent the checkon arm???

> As of today, we do not know if the binary package that we distribute on armel
> really works or not.  I think that this bug reflects well the situation.  Maybe
> the simplest way to close it would be to restrict the build to the amd64
> architecture ? 

If I would understand how the test is switched of on certain
architectures I would rather activate it again and see where it
succeedes.  Than we have some up-to-date data what architecture needs to
be excluded and what not. 

Kind regards

       Andreas.

-- 
http://fam-tille.de