[Debian-med-packaging] Extra patch for ARB : --enable-new-dtags

[Andreas Tille]

Hi Elmar,

to me Tim's patch looks sensible.  If you confirm I could upload a
package with this patch.

Kind regards

     Andreas.

On Mon, Oct 19, 2015 at 03:30:28PM +0100, Tim Booth wrote:
> Hi Elmar and Andreas,
> 
> I notice that a lot of work has gone into packaging the new ARB 6 so I
> had a go at backporting the package for Bio-Linux (Ubuntu 14.04).  I
> found that a basic "debuild -b" failed because of the old ARB 5.5
> package installed on the system.  OK, I can remove the old ARB package
> or else pbuild it no problem, but I did a bit of digging and came up
> with the attached patch.
> 
> I'm sending it via the list rather than bunging it into SVN because I
> want you to look at it and tell me if you've come across the
> --enable-new-dtags thing before?  It looks like this should be the
> default behaviour for all builds but some distros have adopted it and
> others (Debian) did not.
> 
> Aside from fixing my build, this also restores what (to me) would be the
> expected behaviour for $LD_LIBRARY_PATH in the binary package, so I
> would advocate applying this to the package for that reason.  But maybe
> it has a downside I missed?
> 
> Any thoughts?
> 
> TIM
> 
> -- 
> Hanlon's Razor: Never attribute to malice that which can be adequately
> explained by stupidity... but don't rule out malice.

> Apparently back in 1995 the ELF standard was tweaked to handle some
> crufty behaviour of RPATH - see http://blog.tremily.us/posts/rpath/
> but Debian never adopted it.  But for this package we do want it, so
> edd the extra linker flag.
> --- a/Makefile
> +++ b/Makefile
> @@ -196,8 +196,8 @@
>  endif
>  
>  ifeq ($(DEBIAN),1)
> -	lflags += -rpath=/usr/lib/arb/lib -z relro
> -	clflags += -Wl,-rpath=/usr/lib/arb/lib -Wl,-z,relro
> +	lflags += -rpath=/usr/lib/arb/lib -z relro --enable-new-dtags
> +	clflags += -Wl,-rpath=/usr/lib/arb/lib -Wl,-z,relro,--enable-new-dtags
>  endif
>  
>  ifeq ($(DEBUG),1)

> _______________________________________________
> Debian-med-packaging mailing list
> Debian-med-packaging at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-med-packaging


-- 
http://fam-tille.de