[Debian-med-packaging] snakemake ready for review

[Andreas Tille]

Hi Kevin,

On Tue, Sep 15, 2015 at 11:58:21PM +1000, Kevin Murray wrote:
> Hi all,
> 
> My packaging of snakemake[0] is ready for review (and hopefully upload). It's
> my first from-scratch python package, but it all appears to work and has been
> tested in docker.

the package looks fine.  The only thing I'd change is that you should
add a '+dfsg' (or '+ds') to the upstream version number since the
repackaging results in a changed upstream tarball.  This means something
like:


$ git diff
diff --git a/debian/changelog b/debian/changelog
index 7218425..5f9f5cb 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,4 @@
-snakemake (3.4.2-1) UNRELEASED; urgency=low
+snakemake (3.4.2+dfsg-1) UNRELEASED; urgency=low
 
   * Initial release (Closes: #798824)
 
diff --git a/debian/watch b/debian/watch
index f16e098..b4a04dd 100644
--- a/debian/watch
+++ b/debian/watch
@@ -1,4 +1,5 @@
 # Compulsory line, this is a version 3 file
 version=3
 
+opts="repacksuffix=+dfsg,dversionmangle=s/\+dfsg//g" \
 https://bitbucket.org/johanneskoester/snakemake/downloads#tag-downloads .*/v(\d\S*)\.tar\.gz


Would you agree to this or do you have reasons not to choose any postfix
for the version number. 

Kind regards

        Andreas.

-- 
http://fam-tille.de