[Debian-med-packaging] Bug#821015: harvest-tools: FTBFS with memcpy-related errors

[Aaron M. Ucko]

Source: harvest-tools
Version: 1.2-1
Severity: important
Justification: fails to build from source

Hi, Andreas.

Builds of harvest-tools fail on nearly all architectures with errors
related to memcpy.  On most platforms, there are several errors of the
form

  libharvest.a(AnnotationList.o): In function `std::char_traits<char>::copy(char*, char const*, unsigned long)':
  /usr/include/c++/5/bits/char_traits.h:290: undefined reference to `memcpy at GLIBC_2.2.5'

On mips(el), the errors are instead

  /usr/bin/ld: src/harvest/memcpyWrap.o: relocation R_MIPS_HI16 against `__gnu_local_gp' can not be used when making a shared object; recompile with -fPIC
  src/harvest/memcpyWrap.o: error adding symbols: Bad value

These all look like fallout from attempting to deploy a memcpy
wrapper, which moreover appears to make no actual difference.  I would
recommend the following build-system changes:

- Stop compiling with -include src/harvest/memcpyLink.h.
- Stop building memcpyWrap.c at all.
- Build harvesttools directly from the remaining object files,
  as I see no need for an intermediate libharvest.a.  (Alternatively,
  pull harvest.cpp, which defines main, out of the library.)
- Stop linking with -Wl,--wrap=memcpy.  While you're at it, please
  also drop -static-libstdc++, which is inappropriate for Debian.

Could you please take a look?

Thanks!