[Debian-med-packaging] Bug#811866: fixed in hyphy 2.2.6+dfsg-4

[Andreas Tille]

Hi Santiago,

On Sat, Aug 13, 2016 at 07:32:45PM +0200, Santiago Vila wrote:
> found 811866 2.2.6+dfsg-4
> thanks
> 
> Still FTBFS:

Probably not "still" but again since this is a different error.
 
> https://tests.reproducible-builds.org/debian/rbuild/testing/amd64/hyphy_2.2.6+dfsg-4.rbuild.log

It boils down to


...
build/hyphy-2.2.6+dfsg/src/gui/HYChartWindow.cpp:113:1: error: narrowing conversion of '2.3969999999999999e+2' from 'double' to 'unsigned char' inside { } [-Wnarrowing]
 };
 ^
/build/hyphy-2.2.6+dfsg/src/gui/HYChartWindow.cpp:113:1: error: narrowing conversion of '3.0599999999999998e+1' from 'double' to 'unsigned char' inside { } [-Wnarrowing]
/build/hyphy-2.2.6+dfsg/src/gui/HYChartWindow.cpp:113:1: error: narrowing conversion of '2.8050000000000001e+1' from 'double' to 'unsigned char' inside { } [-Wnarrowing]
/build/hyphy-2.2.6+dfsg/src/gui/HYChartWindow.cpp:113:1: error: narrowing conversion of '1.0455e+2' from 'double' to 'unsigned char' inside { } [-Wnarrowing]
/build/hyphy-2.2.6+dfsg/src/gui/HYChartWindow.cpp:113:1: error: narrowing conversion of '1.1730000000000001e+2' from 'double' to 'unsigned char' inside { } [-Wnarrowing]
/build/hyphy-2.2.6+dfsg/src/gui/HYChartWindow.cpp:113:1: error: narrowing conversion of '2.3205000000000001e+2' from 'double' to 'unsigned char' inside { } [-Wnarrowing]
/build/hyphy-2.2.6+dfsg/src/gui/HYChartWindow.cpp:113:1: error: narrowing conversion of '2.3205000000000001e+2' from 'double' to 'unsigned char' inside { } [-Wnarrowing]
/build/hyphy-2.2.6+dfsg/src/gui/HYChartWindow.cpp:113:1: error: narrowing conversion of '8.6700000000000003e+1' from 'double' to 'unsigned char' inside { } [-Wnarrowing]
/build/hyphy-2.2.6+dfsg/src/gui/HYChartWindow.cpp:113:1: error: narrowing conversion of '4.5899999999999999e+1' from 'double' to 'unsigned char' inside { } [-Wnarrowing]
...


Which is caused by:


_HYColor            chartColors [HY_CHART_COLOR_COUNT] = {
    {255*.94, 255*.12, 255*.11 },//(Red)
    {255*.41, 255*.46, 255*.91 },//(Evening Blue)
    {255    , 255*.91, 255*.34 },//(Banana)
    {255*.18, 255*.55, 255*.13 },//(Clover)
    {255*.55, 255*.38, 255*.21 },//(Dirt)
    {255*.42, 255*.09, 255*.69 },//(Royal Violet)
    {255*.09, 255*.29, 255*.51 },//(Sea Blue)
    {255   ,  255*.57, 255*.09 },//(Orange)
    {255*.67, 255*.67, 255*.67 },//(Concrete)
    {255*.85, 255*.27, 255*.42 } //(Carnation)
};


the narrowing conversion in this case is absolutely intended here
obviously.  Is there any more elegant solution for these case than
something like

    s:\.\([0-9][0-9]\):\1/100:g

?

Kind regards

       Andreas.


-- 
http://fam-tille.de