[Debian-med-packaging] Bug#847339: pirs: FTBFS when built with dpkg-buildpackage -A (cp: cannot create regular file [...]: No such file or directory)

[Santiago Vila]

Package: src:pirs
Version: 2.0.2+dfsg-2
Severity: serious
Tags: patch

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
(which is what the "Arch: all" autobuilder would do to build it)
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --with autoreconf --sourcedirectory=src
   dh_testdir -i -O--sourcedirectory=src
   dh_update_autotools_config -i -O--sourcedirectory=src
   debian/rules override_dh_autoreconf
make[1]: Entering directory '/<<BUILDDIR>>/pirs-2.0.2+dfsg'
#cd src && ./genauto.sh
cd src && \
mv INSTALL INSTALL.save && \
autoreconf --install && \
mv INSTALL.save INSTALL && \
cd /<<BUILDDIR>>/pirs-2.0.2+dfsg
configure.ac:9: installing './compile'

[... snipped ...]

 fakeroot debian/rules binary-indep
dh binary-indep --with autoreconf --sourcedirectory=src
   dh_testroot -i -O--sourcedirectory=src
   dh_prep -i -O--sourcedirectory=src
   debian/rules override_dh_auto_install
make[1]: Entering directory '/<<BUILDDIR>>/pirs-2.0.2+dfsg'
dh_auto_install --sourcedirectory=src/stator/gcContCvgBias
make[1]: Leaving directory '/<<BUILDDIR>>/pirs-2.0.2+dfsg'
   debian/rules override_dh_install
make[1]: Entering directory '/<<BUILDDIR>>/pirs-2.0.2+dfsg'
dh_install
mkdir -p debian/pirs/usr/lib/pirs
find src -name "*.pl" -exec cp -a \{\} debian/pirs/usr/lib/pirs \;
rm -f debian/pirs/usr/lib/pirs/autobam.pl
sed -i 's:#!/bin/env:#!/usr/bin/env:' debian/pirs/usr/lib/pirs/*.pl
make[1]: Leaving directory '/<<BUILDDIR>>/pirs-2.0.2+dfsg'
   debian/rules override_dh_installdocs
make[1]: Entering directory '/<<BUILDDIR>>/pirs-2.0.2+dfsg'
dh_installdocs
cp -a src/stator/readme.txt debian/pirs/usr/share/doc/pirs/strator_readme.txt
cp: cannot create regular file 'debian/pirs/usr/share/doc/pirs/strator_readme.txt': No such file or directory
debian/rules:60: recipe for target 'override_dh_installdocs' failed
make[1]: *** [override_dh_installdocs] Error 1
make[1]: Leaving directory '/<<BUILDDIR>>/pirs-2.0.2+dfsg'
debian/rules:17: recipe for target 'binary-indep' failed
make: *** [binary-indep] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit status 2
--------------------------------------------------------------------------------

This happens because debian/pirs/[...] does not exist, as we are creating
arch-independent packages only.

Tha (trivial) patch below should probably work, but I would use
debian/pirs.docs instead to have an even shorter debian/rules.

Please consider uploading in source-only form as soon as you can
(i.e. after the first upload, where source-only uploads are not
allowed yet). That way we will prevent bugs like this one to propagate
to testing and also we will have official build logs available here:

https://buildd.debian.org/status/package.php?p=pirs

Thanks.

--- a/debian/rules
+++ b/debian/rules
@@ -56,6 +56,6 @@ override_dh_link:
 override_dh_installchangelogs:
 	dh_installchangelogs NEWS
 
-override_dh_installdocs:
+override_dh_installdocs-arch:
 	dh_installdocs
 	cp -a src/stator/readme.txt debian/$(DEBPKGNAME)/usr/share/doc/$(DEBPKGNAME)/strator_readme.txt