[Debian-med-packaging] ngs-sdk_1.2.3-2_amd64.changes REJECTED

[Olivier Sallou]

On 01/25/2016 09:26 PM, Andreas Tille wrote:
> Hi,
>
> On Mon, Jan 25, 2016 at 05:00:19PM +0000, Thorsten Alteholz wrote:
>> Hi Olivier,
>>
>> such statements doesn't really fit into main:
>>  * Copyright (c) 2006, Oracle and/or its affiliates. All rights reserved.
>>  * ORACLE PROPRIETARY/CONFIDENTIAL.  Use is subject to license terms.
>>
>> ngs-1.2.3/ngs-sdk/language/java/jni.h
>> ngs-1.2.3/ngs-sdk/language/java/jni_md.h
Sending an update to use Debian JNI. I keep code however in source tree,
adding license for this code.

Olivier
> These files can also be found in
>
>    /usr/lib/jvm/default-java/include/
>
> Do you think it is possible to use these (while patching these three
> files
>
> $ grep '"jni[_md]*.h"' ngs-sdk/language/java/*
> ngs-sdk/language/java/jni_ErrorMsg.hpp:#include "jni.h"
> ngs-sdk/language/java/jni.h:#include "jni_md.h"
> ngs-sdk/language/java/jni_String.hpp:#include "jni.h"
>
> and use <> instead of "" (all other include statements are just using
> <>).
>
> If you check for instance:
>
> diff -ub /usr/lib/jvm/default-java/include/jni.h ngs-sdk/language/java/jni.h 
>
> This is basically the same file.  The files jni_md.h have some
> differences but I guess this is since
> /usr/lib/jvm/default-java/include/jni_md.h is a symlink to linux/jni_md.h
> and may be the file in ngs-sdk supports some other OSes - at least I found
> some
>
> -#define JNICALL
> +#ifdef _WIN32
>
> What do you think about this plan?  Alternatively we could take over the
> *full* copyright from the files in /usr/lib/jvm/default-java/include/
> that is more explicit.
>
> Kind regards
>
>         Andreas.
>> At least you should add the "license terms".
> This would save us from 
>

-- 
Olivier Sallou
IRISA / University of Rennes 1
Campus de Beaulieu, 35000 RENNES - FRANCE
Tel: 02.99.84.71.95

gpg key id: 4096R/326D8438  (keyring.debian.org)
Key fingerprint = 5FB4 6F83 D3B9 5204 6335  D26D 78DC 68DB 326D 8438