[Debian-med-packaging] Bug#753809: ginkgocadx and certain dicom files

[Karsten Hilbert]

Hi David,

thanks for the clarification.

> On 1/31/16 3:37 PM, Karsten Hilbert wrote:
> 
> >Sure, but so far I'd have assumed "garbage in, SAME garbage out".
> 
> There is no reason to assume this.

Indeed. I should have been more precise:

	IF garbage in AND if garbage ACCEPTED, then SAME garbage
	OUT if NOT UNAMBIGOUSLY fixable

Sounds right ?  :)

> A simple example of the importance of the correct encoding
> of the data set and the need to be able to decode it, is
> indexing ... if the data set cannot be parsed, then how can
> one extract the patient and study and series identifiers to
> use in the database so as to respond correctly to a query?

Dang, there goes my logic :-)

> >However, that fact doesn't have anything to do with the bug I reported.
> 
> Now hopefully you see why it does.

I much better appreciate what is involved thanks to your
explanations.

> What you reported does not sound like a bug in the
> implementation, it is a "feature
> request" to cope with a particular pattern of invalid input,
> for which a fix might not necessarily lead to coping with
> other patterns of invalid input.
> 
> Beyond that one bad file, a feature request to "store and index
> any garbage that even vaguely resembles a DICOM instance" is
> a pretty ambitious demand.

What struck me as odd: It used to work !  Suddenly Ginkgo
CADx stopped redisplaying roundtripped studies from the same
original modality.

So, previously:

	- get from modality onto CDROM
	- read CDROM
	- display fine
	- send to orthanc
	- retrieve from orthanc
	- display fine

Now:

	- get from very same modality onto CDROM
	- read CDROM
	- display fine
	- send to orthanc
	- retrieve from orthanc
	- display breaks

However, I now see that "very same modality" might stand on
shaky ground as while it is certainly the same X-ray machine
the software handling that modality may have (and has)
changed at least in version.

Karsten
-- 
GPG key ID E4071346 @ eu.pool.sks-keyservers.net
E167 67FD A291 2BEA 73BD  4537 78B9 A9F9 E407 1346