[Debian-med-packaging] Bug#815041: gdpc: implicit function declarations causing errors in build log checks

[Logan Rosen]

Package: gdpc
Version: 2.2.5-4
Severity: important
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu xenial ubuntu-patch

Hi,

As you can see in the build log checks for gdpc in Debian [1], the build logs
contain implicit function declarations due to the use of deprecated glib
functions. The implicit declaration of functions can cause problems on 64-bit
architectures, as described here [2].

Implicit function declarations actually cause an FTBFS on 64-bit architectures
in Ubuntu, which prompted the attached patch.

In Ubuntu, the attached patch was applied to achieve the following:

  * Merge from Debian unstable. Remaining changes:
    - debian/patches/41_glib_deprecated_funcs.patch: Converted uses of
      deprecated glib functions, fixing FTBFS on 64-bit buildds.

Thanks for considering the patch.

Logan Rosen

[1] https://qa.debian.org/bls/packages/g/gdpc.html
[2] https://wiki.debian.org/ImplicitPointerConversions

-- System Information:
Debian Release: stretch/sid
  APT prefers xenial-updates
  APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500, 'xenial'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.4.0-2-generic (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gdpc_2.2.5-4ubuntu1.debdiff
Type: text/x-diff
Size: 2264 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20160218/a4e587d8/attachment.diff>