[Debian-med-packaging] What should be done with libbio-das-lite-perl

[gregor herrmann]

On Tue, 05 Jan 2016 14:35:40 +0100, Andreas Tille wrote:

> >  2) Make package properly maintained by debian-med, and find some other
> >     uploader (the existing maintainer is no longer active).
> I updated
>    svn://anonscm.debian.org/debian-med/trunk/packages/ensembl/libbio-das-lite-perl/trunk/
> in any case (regarding packaging and latest upstream version).

I see "source format 3.0 (quilt)" in svn log but the commit touches
only d/changelog.
 
> Questions to the pkg-perl team:
> 
>   1. Would you prefer to maintain this package?  This would be fine
>      for me.

As you prefer.
 
>   2. If we should keep it in Debian Med I have some remaining questions
>      about the packaging:
> 
>      a) Upstream tarball contains a copy of itself (Bio-Das-Lite-2.11.tar.gz)
>         How to you deal with this usually (ignore or repack)?

I'd ignore it.
 
>      b) I needed a nasty override since the clean target *created* some
>         new files MYMETA*.  I fixed this using
> 
> 	override_dh_clean:
>         	dh_clean
> 	        rm -f MYMETA*
> 
>         but I wonder whether this is a proper solution or whether this
>         might be somehow connected to my main problem with this package
>         which is a failed test:

I think the approach is correct.
(I prefer debian/clean but this has the same effetct.)

Ah, I found were it come from: there's a Makefile in the tarball.

So this works as well:

-override_dh_clean:
-       dh_clean
-       rm -f MYMETA*
+override_dh_auto_clean:
+       $(RM) -vf Makefile
+       dh_auto_clean

Or even simpler: tell dh to use M::B:

-       dh $@
+       dh $@ --buildsystem=perl_build

and remove override_dh_clean
 
>      c) One failed test:
> 
>    debian/rules override_dh_auto_test
> make[1]: Entering directory '/build/libbio-das-lite-perl-2.11'
> http_proxy= dh_auto_test -- --test_files="t/00-critic.t t/00-distribution.t t/00-pod.t t/00-podcoverage.t t/06-singledsn-singleseg.t t/20-authentication.t t/21-proxy.t t/40-dna.t t/45-sequence.t t/50-entry_poin
> <------>perl Build test --verbose 1 "--test_files=t/00-critic.t t/00-distribution.t t/00-pod.t t/00-podcoverage.t t/06-singledsn-singleseg.t t/20-authentication.t t/21-proxy.t t/40-dna.t t/45-sequence.t t/50-en
> t/00-critic.t ............... skipped: Author test.  Set $ENV{TEST_AUTHOR} to a true value to run.
> No such file: build.tap
> 
> #   Failed test 'Checking MANIFEST integrity'
> #   at /usr/share/perl5/Test/Distribution.pm line 249.
> # Looks like you failed 1 test of 9.
> t/00-distribution.t ..........
> 1..9
> not ok 1 - Checking MANIFEST integrity
> ok 2 - use Bio::Das::Lite;
> ok 3 - Bio::Das::Lite defines a version
> ok 4 - POD test for blib/lib/Bio/Das/Lite.pm
> ok 5 - MANIFEST exists
> ok 6 - README exists
> ok 7 - Changes(.pod)? or ChangeLog(.pod)? exists
> ok 8 - Build.PL or Makefile.PL exists
> ok 9 - Pod Coverage ok
> Dubious, test returned 1 (wstat 256, 0x100)
> Failed 1/9 subtests.
> ...
> Test Summary Report
> -------------------
> t/00-distribution.t       (Wstat: 256 Tests: 9 Failed: 1)
>   Failed test:  1
>   Non-zero exit status: 1
> Files=17, Tests=59,  1 wallclock secs ( 0.06 usr  0.00 sys +  0.91 cusr  0.05 csys =  1.02 CPU)
> Result: FAIL
> Failed 1/17 test programs. 1/59 subtests failed.

t/00-distribution.t is for the upstream author to check if everything
is fine before releasing, which obviously is not the case here
(.tar.gz in .tar.gz, forgotten Makefile); I'm not sure what's wrong
with MANIFEST in detail but it fits the whole picture (maybe it's
build.tap). - I'd just skip the test, and the machinery for it is
already in d/rules.

"Complete" svn diff attached.


Cheers,
gregor

-- 
 .''`.  Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Bettina Wegner: Heimweh nach Heimat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libbio-das-lite-perl_rules.diff
Type: text/x-diff
Size: 730 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20160105/ceb614bf/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: Digital Signature
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20160105/ceb614bf/attachment.sig>