[Debian-med-packaging] Bug#812378: Bug#812378: snap-aligner: FTBFS: no match for max(unsigned long, _int64)

[Michael Crusoe]

Control: forwarded https://github.com/amplab/snap/issues/68

Thank you Aaron for your reports.

x32 is out of my league; and I suspect outside of upstream's interest
though I have still reported it there for completeness.

I made the suggested change but it wasn't sufficient:

g++ -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -MMD
-ISNAPLib -Wdate-time -D_FORTIFY_SOURCE=2  -c -o SNAPLib/SortedDataWriter.o
SNAPLib/SortedDataWriter.cpp
SNAPLib/SortedDataWriter.cpp: In member function 'bool
SortedDataFilterSupplier::mergeSort()':
SNAPLib/SortedDataWriter.cpp:339:86: error: no matching function for call
to 'max(long long unsigned int, _int64)'
             min(UINT64_C(1) << 23, max(UINT64_C(1) << 17, bufferSpace /
blocks.size()))); // 128kB to 8MB buffer space per block

          ^
In file included from /usr/include/c++/5/algorithm:61:0,
                 from SNAPLib/stdafx.h:13,
                 from SNAPLib/SortedDataWriter.cpp:19:
/usr/include/c++/5/bits/stl_algobase.h:265:5: note: candidate:
template<class _Tp, class _Compare> const _Tp& std::max(const _Tp&, const
_Tp&, _Compare)
     max(const _Tp& __a, const _Tp& __b, _Compare __comp)
     ^
/usr/include/c++/5/bits/stl_algobase.h:265:5: note:   template argument
deduction/substitution failed:
SNAPLib/SortedDataWriter.cpp:339:86: note:   deduced conflicting types for
parameter 'const _Tp' ('long long unsigned int' and '_int64 {aka long long
int}')
             min(UINT64_C(1) << 23, max(UINT64_C(1) << 17, bufferSpace /
blocks.size()))); // 128kB to 8MB buffer space per block

          ^
In file included from /usr/include/c++/5/algorithm:61:0,
                 from SNAPLib/stdafx.h:13,
                 from SNAPLib/SortedDataWriter.cpp:19:
/usr/include/c++/5/bits/stl_algobase.h:219:5: note: candidate:
template<class _Tp> const _Tp& std::max(const _Tp&, const _Tp&)
     max(const _Tp& __a, const _Tp& __b)
     ^
/usr/include/c++/5/bits/stl_algobase.h:219:5: note:   template argument
deduction/substitution failed:
SNAPLib/SortedDataWriter.cpp:339:86: note:   deduced conflicting types for
parameter 'const _Tp' ('long long unsigned int' and '_int64 {aka long long
int}')
             min(UINT64_C(1) << 23, max(UINT64_C(1) << 17, bufferSpace /
blocks.size()))); // 128kB to 8MB buffer space per block

          ^
<builtin>: recipe for target 'SNAPLib/SortedDataWriter.o' failed

On Sat, Jan 23, 2016 at 12:51 AM Aaron M. Ucko <ucko at debian.org> wrote:

> Source: snap-aligner
> Version: 0.18~1.0~beta.18+dfsg1-1
> Severity: important
> Justification: fails to build from source
>
> 32-bit builds of snap-aligner that get past #812376 still fail:
>
>   SNAPLib/SortedDataWriter.cpp:338:70: error: no matching function for
> call to 'max(long unsigned int, _int64)'
>                min(1UL << 23, max(1UL << 17, bufferSpace /
> blocks.size()))); // 128kB to 8MB buffer space per block
>
> So far, this error has only occurred on x32, but I expect *i386
> builds will fail the same way.  I'd suggest including <stdint.h> and
> substituting UINT64_C(1) for both occurrences of 1UL here.  Could you
> please take a look?
>
> Thanks!
>
> _______________________________________________
> Debian-med-packaging mailing list
> Debian-med-packaging at lists.alioth.debian.org
>
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-med-packaging
>
-- 
Michael R. Crusoe     CWL Community Engineer     crusoe at ucdavis.edu
<mcrusoe at msu.edu>
Common Workflow Language project    University of California, Davis
https://impactstory.org/MichaelRCrusoe http://twitter.com/biocrusoe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20160124/a2d0629c/attachment.html>