[Debian-med-packaging] Bug#777791: [PATCH] ball: ftbfs with GCC-5

[Danny Edel]

Hello Andreas,

I have had some spare time and spent it on the ball package.  I hope
that helps you in getting the package back into Debian.

Some notes regarding the patch:

* I dropped the gcc5.patch, since it created an ambiguous overload of
getline -- Upstream added one themselves in the meantime.

* The patches in debian/patches/backports/ are all cherry-picked from
the upstream git repository at github.com/BALL-project/ball -- their
first line will tell you the commit ID.  Take a look at the branch
qt5_latest if they are not yet in master.
They were created with git format-patch -1 <commit>, I hope that's all
right.

* The most problematic part was DOCKING/COMMON/poseClustering.h.  It
seems to break with boost-1.56, because it assumes a certain class is
copyable that has been adapted to c++11's "move" idea.
The commit that breaks it is
https://github.com/boostorg/graph/commit/cb26ccf

I have used a very crude workaround (I have defined a BOOST_* symbol
suggesting that the compiler would not support moves), this needs to be
properly ported to current boost by BALL upstream.  Please try to get in
contact with upstream, and have them properly port the code.

* The upstream code is also not yet ready for libeigen3 version 3.3
(currently in beta) that drops some compatibility code.  I added a
Build-Conflicts to make the buildd's aware of that.  This also needs to
be ported by upstream.

In order to build the package anyway, I had to add to my sources.list a
snapshot.debian.org containing the older version (its header-only, so
it's compiled into the binary and does not generate a run-time
dependency).  sources.list line containing a suitable old version:

deb http://snapshot.debian.org/archive/debian/20150924T154447Z sid main



* I activated the test suite in d/rules -- mainly because I was not sure
if my crude workaround broke anything.
On my test builds, the Socket_test sometimes™ failed.  Maybe there is a
race condition, I don't know.  Could also be my old hardware bitrotting
away...

* Since I used the older libeigen, I set it as a "system" library in
cmake, which prevents the compile log from generating warnings when
eigen uses deprecated features  (just distracted me while working on
ball, feel free to drop that patch).


The patch is based against b915af8eff, which was today (jan 26) the
current master in the debian-med repository.


After all this hacking, the package builds and the resulting .deb's seem
usable to me, but I dont understand enough biochemics to make anything
out of it : )


I can't tell myself if the patch is of acceptable quality, please have a
look over it before adopting.  Feedback would be much appreciated, this
is my first non-trivial contribution.


I hope this helps,


- Danny
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-ball-ftbfs.patch
Type: text/x-patch
Size: 21589 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20160126/3529b740/attachment-0001.bin>