[Debian-med-packaging] Bug#831165: snap: FTBFS with GCC 6: zoeTools.c:152:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]

[Lucas Nussbaum]

Source: snap
Version: 2013-11-29-2
Severity: serious
Tags: stretch sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20160713 qa-ftbfs
Justification: FTBFS with GCC 6 on amd64

Hi,

During a rebuild of all packages in sid using the gcc-defaults package
available in experimental to make GCC default to version 6, your package failed
to build on amd64. For more information about GCC 6 and Stretch, see:
- https://wiki.debian.org/GCC6
- https://lists.debian.org/debian-devel-announce/2016/06/msg00007.html

Relevant part (hopefully):
> cc -O2 -Wall -Werror -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -c -o zoeTools.o zoeTools.c
> zoeTools.c: In function 'itoa':
> zoeTools.c:152:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
>   if (sign < 0)
>   ^~
> zoeTools.c:154:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
>    s[i] = '\0';
>    ^
> cc1: all warnings being treated as errors
> make[6]: *** [zoeTools.o] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2016/07/13/snap_2013-11-29-2_unstable_gcc6.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.