[Debian-med-packaging] Bug#753809: Bug#753809: ginkgocadx, orthanc and sending/receiving data

[Gert Wollny]

Hello, 

firstly, thanks for the help Michael. 

On Thu, 2016-03-03 at 16:54 +0100, Michael Onken wrote:
> I don't think we made serious changes in DCMTK's networking code,
> instead, we really try hard to keep it backward compatible (if we
> change something at all).
I can confirm that this is not the problem: with 

  movescu -v -S -aec ORTHNAC -aet GINKGO -aem GINKGO --port 11112 \
    -od . localhost 4242 -k StudyInstanceUID=XXXXX 

I was able to retrieve the data.  


> Also, if its easily possible in the source code, try to set a more
> detailed DCMTK log level [1]

I've attached the logs of ginkgocadx and orthnac. It seems that orthnac
sends a message, and ginkgocadx receives it, but then it fails in
sending an answer. 

The code in question is in this file: 
https://github.com/gerddie/ginkgocadx/blob/master/cadxcore/commands/inc
omingdicomassociationcommand.cpp lines 418+ 

The call that fails is DIMSE_storeProvider in line 458. 

The patch against the original Ginkgocadx is very simple - the first
two defines are there to avoid including the according headers, because
they make problems with Unicode, and are not really used, everything
looks innocent enough: 

--- 
+#define DCMTK_LOG4CPLUS_TRACELOGGER_H
+#define DCMTK_LOG4CPLUS_LOGGING_MACROS_HEADER_
+
 #include <wx/string.h>
 
 #include <api/imodelointegracion.h>
@@ -193,7 +208,7 @@
 GADAPI::PACS::IncomingDicomAssociationCommandParams::~In...ndParams()
 {
        if (m_pAssoc != NULL) {
-               CONDITION cond = ASC_dropSCPAssociation(m_pAssoc);
+               OFCondition cond = ASC_dropSCPAssociation(m_pAssoc);
                OFString temp_str;
 
                if (cond.bad())
@@ -223,7 +238,7 @@
 }
 
 void GADAPI::PACS::IncomingDicomAssociationCommand::Execute() {
-  CONDITION cond = EC_Normal;
+  OFCondition cond = EC_Normal;
   OFString temp_str;
 
   T_ASC_Association* assoc = m_pIncommingassociationParams->m_pAssoc;

---

Best, 
Gert 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: GinkgoLog.log
Type: text/x-log
Size: 347462 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20160303/ee951345/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Orthanc.log
Type: text/x-log
Size: 8192 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20160303/ee951345/attachment-0007.bin>