[Debian-med-packaging] Bug#812626: libfreecontact-perl: FTBFS - Parse errors: Bad plan. You planned 10 tests but ran 6.

[Jonas Smedegaard]

Quoting Andreas Tille (2016-03-09 10:30:29)
> Hi Michael,
> 
> On Mon, Feb 22, 2016 at 09:50:41AM +0100, Michael Tautschnig wrote:
> > Control: severity -1 wishlist
> > Control: retitle -1 libfreecontact-perl: FTBFS when optimisation is disabled
> > 
> > On Wed, Jan 27, 2016 at  8:21:22 +0100, Andreas Tille wrote:
> > > tags 812626 unreproducible
> > > thanks
> > > 
> > > On Wed, 27 Jan 2016 gregor herrmann wrote:
> > > > 
> > > > On Tue, 26 Jan 2016 21:14:35 +0100, Andreas Tille wrote:
> > > > 
> > > > > > I cloned the git repo (very handy :)) and had a look, but I can't
> > > > > > reproduce the test failure, not even when running them manually under
> > > > > > high load.
> > > > > Hmmmm, I should have mentioned this: I also can not reproduce the
> > > > > problem.
> > > > 
> > > > Ok, maybe the submitter can shed some light on this issue.
> > > 
> > > Michael, could you please be more verbose about the build conditions
> > > since two people can not reproduce this independently.
> > >    
> > [...]
> > 
> > Apologies for taking so long to get back to this one. I have now been able to
> > reproduce both the failing and the non-failing case. The key is to compile
> > with/without optimisation. Thus:
> > 
> > Clean environment -> build succeeds
> > export DEB_BUILD_OPTIONS="noopt" -> build fails
> > 
> > There may be reasons that optimisation is required, in which case it would be
> > nice if the build failed early.
> 
> Thanks for the clarification.  I wonder whether inside the Perl team
> some experiences exist regarding failures when doing no optimisation.
> 
> Would you suggest adding a check like this
> 
> ifeq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))
>         echo "This package needs to be build with optimisation."
>         false
> endif
> 
> to debian/rules to comply with your request?

That is not perl but make.

This (untested) is slightly more elegant:

ifeq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))
        $(error This package needs to be build with optimisation.)
endif

I believe not being able to build without optimization is a violation of 
Policy.  Even if only a "should", definitely better to try get to the 
bottom of this (read: give it more than 2 weeks and maybe also a larer 
audience before giving up).


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20160309/83535dea/attachment.sig>