[Debian-med-packaging] Bug#812011: snap: FTBFS with GCC 6: self-comparison always evaluates

[Andreas Tille]

Hi,

the patch sounds sensible to me - thus I've uploaded it.

Thanks a lot for your work on this

     Andreas.

On Sat, Apr 30, 2016 at 05:48:14PM +0100, Sascha Steinbiss wrote:
> Hi all,
> 
> I have committed a fix for this to SVN. This required changing the (likely buggy) behaviour of the zoeHSPCmpQuery and zoeHSPCmpSbjct functions to do the correct comparisons.
> The patched version builds for me now with the unstable gcc and gcc-6 from experimental.
> 
> Cheers
> Sascha
> 
> 
> On Tue, 19 Jan 2016 20:29:47 -0800 Martin Michlmayr <tbm at hpe.com> wrote:
> > Package: snap
> > Version: 2013-11-29-1
> > Severity: important
> > User: debian-gcc at lists.debian.org
> > Usertags: ftbfs-gcc-6
> > 
> > This package fails to build with GCC 6.  GCC 6 has not been released
> > yet, but it's expected that GCC 6 will become the default compiler for
> > stretch.
> > 
> > Note that only the first error is reported; there might be more.  You
> > can find a snapshot of GCC 6 in experimental.  To build with GCC 6,
> > you can set CC=gcc-6 CXX=g++-6 explicitly.
> > 
> > You may be able to find out more about this issue at
> > https://gcc.gnu.org/gcc-6/changes.html
> > 
> > > sbuild (Debian sbuild) 0.67.0 (26 Dec 2015) on dl580gen9-02.hlinux
> > ...
> > > gcc -O2 -Wall -Werror -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -c -o zoeAlignment.o zoeAlignment.c
> > > zoeAlignment.c: In function ‘zoeHSPCmpQuery ':
> > > zoeAlignment.c:678:50: error: self-comparison always evaluates to false [-Werror=tautological-compare]
> > >   else if (h1->q_start > h2->q_start && h2->q_end > h2->q_end) return  1;
> > >                                                   ^
> > > 
> > > zoeAlignment.c: In function 'zoeHSPCmpSbjct':
> > > zoeAlignment.c:684:50: error: self-comparison always evaluates to false [-Werror=tautological-compare]
> > >   else if (h1->s_start > h2->s_start && h2->s_end > h2->s_end) return  1;
> > >                                                   ^
> > > 
> > > cc1: all warnings being treated as errors
> > > Makefile:110: recipe for target 'zoeAlignment.o' failed
> > 
> > -- 
> > Martin Michlmayr
> > Linux for HPE Helion, Hewlett Packard Enterprise
> > 
> > 
> 
> _______________________________________________
> Debian-med-packaging mailing list
> Debian-med-packaging at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-med-packaging

-- 
http://fam-tille.de