[Debian-med-packaging] FW4SPL package

Wed Nov 23 11:40:17 UTC 2016

Hi Andreas,

Thanks again for your valuable help. I finally succeeded to build the
camp and fw4spl packages. For fw4spl there is a big version bump, since
I updated to 0.11.0.2. A major part of the patches in the previous
packages were already fixed in this branch. So I removed some patches
and updated other ones.

Though, I have few questions left.

1. I noticed in history that Corentin restricted fw4spl to "amd64" for a
while and then he switched to "all". I think he was wrong and wanted to
switch to "any" instead, am I correct ? Then honestly, I can't ensure
that fw4spl can compile and work on other architectures since we never
tested it (we have an android build, so with arm, but it works with a
complete different toolchain build). So I feel a bit embarrassed by
letting this flag to "any" and then pray for the build to succeed. So I
would argue to restrict to amd64. Do you have any advice ?

2. Lintian reports me some errors in fw4spl for each of the libraries we
put in share/ :

E: fw4spl: arch-dependent-file-in-usr-share
usr/share/fw4spl/activities_0-1/libactivities_0-1.so.0.1

I guess that this is because we are not supposed to put binaries in
/usr/share. However this is an annoying case for us because we use the
concept of "Bundles" that can be loaded at runtime, and inside these
bundles, there is a mix of binaries and resource files. We could
consider to split libraries and resources that so that instead of having
this :

/usr/share/fw4spl/activities_0-1
activities.xsd
libactivities_0-1.so
libactivities_0-1.so.0
libactivities_0-1.so.0.1
plugin.xml

we would have:

/usr/lib/fw4spl/activities_0-1
libactivities_0-1.so
libactivities_0-1.so.0
libactivities_0-1.so.0.1

/usr/share/fw4spl/activities_0-1
activities.xsd
plugin.xml

But this demand us to modify deeply our bundle loading code to support
this. This is feasible, but maybe not immediately. Do you think the
current situation is acceptable ?

3. I have the following lintian error:
E: fw4spl source: source-is-missing
Apps/VRRender/doc/source/_static/jquery.js line length is 694 characters
(>512)

This file is present in the source but not used in the final package,
shall I put it in "debian/missing-sources" ?

4. I have not tackled the reopening of the bugs, could you please
confirm that I have to do that through the mailing-list and then mention
the bugs in the debian/changelog to close them ?

5. Depending on your answer on the previous points, can I push my
modifications on camp and fw4spl repos ?

Thanks a lot for your time and your advice. :)

Le 02/11/2016 à 13:12, Andreas Tille a écrit :
> Hi Flavien,
> 
> On Wed, Nov 02, 2016 at 12:26:46PM +0100, Flavien Bridault wrote:
>> This is an answer to a private email discussion I started with Andreas
>> Tille <andreas at an3as.eu>. I'm sorry I started this discussion outside of
>> the debian mailing-list but I was not well aware of the right way to
>> contact you. Thank you btw Andreas for your kind answer. :)
> 
> You are welcome.
>  
>> So if you agree to welcome us again
> 
> Phrases like this do not really fit into Debian philosophy:  Debian is a
> Do-ocracy so the doer decides what gets done.  If you do some work on
> freely licensed code that is technically sensible and fits into Debian
> policy there is no real point to ask for agreement of people.  Well, as
> long as you are not a Debian Developer you need to convince some DD to
> upload your code but I confirmed this before.  And yes, I think you are
> welcome anyway in the Debian Med team. :-)
> 
>> despite our past mistakes and lack of support,
> 
> I think this was sufficiently explained and can be simply fixed by a
> bug free fw4spl package.
> 
>> I would be pleased to be the new maintainer of the debian
>> package. Of course I can also take care of the packaging of the camp
>> library which is a dependency of FW4SPL.
> 
> It's good to know that you'll also care for camp.
> 
>> However I must admit I start from scratch in the Debian world. I already
>> registered alioth.debian.org this morning. I started to read all the
>> required documentation and I will come back to you when needed, since
>> you gently offered your help.
> 
> Since the actual packaging is done and probably "only" some upgrade of
> the upstream code is needed this is perhaps easier than expected.  I
> think (hope) the Debian Med policy document[1] will be your friend to
> learn about the workflow inside the Debian Med team and if needed
> gives some links to basic packaging information.
> 
> If you follow the information about alioth login you should be able
> to do `ssh git.debian.org` (when using ssh-agent without typing your
> password over and over).  If this is the case you can do
> 
>    ssh://git.debian.org/git/debian-med/camp.git
>    ssh://git.debian.org/git/debian-med/fw4spl.git
> 
> In both cases you should do something like
> 
>    dch -i
> 
> add changelog entries
> 
>    * Remove Corentin Desfarges as Uploader
>    * Add myself as Uploader
> 
> and do what you wrote there inside the debian/control file.  You should
> commit the change with Git.  Looking at debian/control I'd recommend to
> do
> 
>    cme fix dpkg-control
> 
> (see policy[1] what packages need to be installed to make this working)
> which should fixe Vcs-fields and bumps Standards-Version (I guess this
> version bump is safe - but as a beginner please check the web about the
> meaning of Debian policy versioning which is represented in this field).
> Please also mention this change in debian/changelog (either by manually
> editing debian/changelog or by using `dch` - see man dch).
> 
> As far as I can see there is no new version of camp available.  Please
> try
> 
>    gbp buildpackage
> 
> to see whether your build environment is OK and you can reproduce the
> build.  If you are happy with the result please tell so here - if you
> have problems just let us know as well.
> 
> As far as I can see there is fw4spl version 0.10.2.2 available upstream.
> You can download it via
> 
>    uscan --verbose
> 
> Once this is downloaded you can follow the Debian Med policy document[1]
> and import the resulting source tarball via
> 
>    gbp import-orig --pristine-tar ../fw4spl_0.10.2.2.orig.tar.gz
> 
> Please adjust the version number in debian/changelog and add an entry
> 
>    * New upstream version
> 
> Now check whether it builds nicely via
> 
>    gbp buildpackage
> 
> and tell us here about results or problems.
> 
>> All the critical should be fixed now but they are for sure not yet
>> documented in the debian changelog.
> 
> It would be good to address the bugs inside the debian/changelog and
> close the according bugs.
> 
>> I'll do this as soon as I learn how
>> I do this.
> 
> Hope the hints above are sufficient to get you started.
> 
>> Do you have any deadline for the next Debian release ?
> 
> Debian will freeze for the next stable release at 5th January 2017.
> Since fw4spl needs to pass the new queue again and we need to assume
> that ftpmaster takes about 4 weeks to process new packages you should be
> ready to 1.12.2016 with the packaging.
> 
> Thanks for picking up fw4spl packaging
> 
>      Andreas.
> 
> [1] http://debian-med.alioth.debian.org/docs/policy.html
> 

*Flavien BRIDAULT*
Ingénieur de Recherche

fbridault at ircad.fr

*IRCAD France*
1, place de l'Hôpital - 67091 Strasbourg Cedex - FRANCE

http://www.ircad.fr/ <http://www.ircad.fr/>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20161123/ba3659d7/attachment-0001.sig>