[Debian-med-packaging] Bug#839320: Would you upload with disabled test?

[Sascha Steinbiss]

Hi Andreas and Adrian,

>>> since there are no responses so far I wonder how to proceed with the
>>> package. 
>>
>> Yes, that's one of the bugs that has been on my list for a while as well...

Regarding the original bug, I have confirmed again with upstream that
it's fine to disable these tests, which I have done in Git. Builds fine
for me now.

Does everyone agree? I can make an upload if so. I have also filed an
issue upstream for them to make the tests a bit more robust.

>>> I need to admit I get a different error when trying to build
>>> the current state of gubbins packaging Git:
>>>
>>> gcc -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2 -I../tests -pthread -g -O2 -fdebug-prefix-map=/build/gubbins-2.1.0=. -fstack-protector-strong -Wformat -Werror=format-security -c -o ../tests/run_all_tests-run_all_tests.o `test -f '../tests/run_all_tests.c' || echo './'`../tests/run_all_tests.c
>>> /bin/bash ../libtool  --tag=CC   --mode=link gcc -I../tests -pthread -g -O2 -fdebug-prefix-map=/build/gubbins-2.1.0=. -fstack-protector-strong -Wformat -Werror=format-security  -Wl,-z,relro -Wl,-z,now -o run_all_tests ../tests/run_all_tests-check_branch_sequences.o ../tests/run_all_tests-check_gubbins.o ../tests/run_all_tests-check_parse_phylip.o ../tests/run_all_tests-check_snp_searching.o ../tests/run_all_tests-check_snp_sites.o ../tests/run_all_tests-check_vcf_parsing.o ../tests/run_all_tests-helper_methods.o ../tests/run_all_tests-run_all_tests.o -lcheck libgubbins.la -lz -lm  -lrt -lsubunit 
>>> libtool: link: gcc -I../tests -pthread -g -O2 -fdebug-prefix-map=/build/gubbins-2.1.0=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o .libs/run_all_tests ../tests/run_all_tests-check_branch_sequences.o ../tests/run_all_tests-check_gubbins.o ../tests/run_all_tests-check_parse_phylip.o ../tests/run_all_tests-check_snp_searching.o ../tests/run_all_tests-check_snp_sites.o ../tests/run_all_tests-check_vcf_parsing.o ../tests/run_all_tests-helper_methods.o ../tests/run_all_tests-run_all_tests.o  -lcheck ./.libs/libgubbins.so -lz -lm -lrt -lsubunit -pthread
<snip>
>>> collect2: error: ld returned 1 exit status
>>> Makefile:742: recipe for target 'run_all_tests' failed
>>> make[4]: *** [run_all_tests] Error 1
>>
>> This looks like a completely different issue altogether I have never
>> seen, for me it was always failing tests.
>> ...
> 
> That's #837445 in the check package, which became fatal with gcc-6 in 
> unstable defaulting to PIE since this week Tuesday.

I can't reproduce this in a current unstable chroot; it looks like
#837445 has been fixed.

Cheers
Sascha