[Debian-med-packaging] Bug#856233: edtsurf FTBFS on architectures where char is unsigned

[Adrian Bunk]

Source: edtsurf
Version: 0.2009-3
Severity: serious
Tags: stretch sid

From an armhf build:

...
make[1]: Entering directory '/home/debian/edtsurf-0.2009'
g++ -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/home/debian/edtsurf-0.2009=. -fstack-protector-strong -Wformat -Werror=format-security -c ParsePDB.cpp -o ParsePDB.o
In file included from ParsePDB.cpp:12:0:
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
 1,1,1, 1,1,-1, 1,-1,1, -1,1,1, 1,-1,-1, -1,-1,1, -1,1,-1, -1,-1,-1};
                                                                   ^
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
CommonPara.h:49:67: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
ParsePDB.cpp: In member function ‘bool ParsePDB::loadpdb(char*)’:
ParsePDB.cpp:1462:28: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result [-Wunused-result]
   fgets(oneline,255,filein);
                            ^
Makefile:7: recipe for target 'ParsePDB.o' failed
make[1]: *** [ParsePDB.o] Error 1
make[1]: Leaving directory '/home/debian/edtsurf-0.2009'
dh_auto_build: make -j1 returned exit code 2
debian/rules:8: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2