[Debian-med-packaging] Bug#853609: perm: ftbfs with GCC-7

[Matthias Klose]

Package: src:perm
Version: 0.4.0-2
Severity: normal
Tags: sid buster
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-7

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-7/g++-7, but succeeds to build with gcc-6/g++-6. The
severity of this report may be raised before the buster release.
There is no need to fix this issue in time for the stretch release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc7-20170126/perm_0.4.0-2_unstable_gcc7.log
The last lines of the build log are at the end of this report.

To build with GCC 7, either set CC=gcc-7 CXX=g++-7 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-7/porting_to.html

[...]
MappingResult.h: In function 'bool printAPairedMappingInPerM(FileOutputBuffer*, CMappingResult&, CMappingResult&, int, bool)':
MappingResult.h:265:26: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
         if(m1.QScores == '\0' || m2.QScores == '\0') {
                          ^~~~
MappingResult.h:265:48: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
         if(m1.QScores == '\0' || m2.QScores == '\0') {
                                                ^~~~
MappingResult.h:275:26: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
         if(m1.QScores == '\0' || m2.QScores == '\0') {
                          ^~~~
MappingResult.h:275:48: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
         if(m1.QScores == '\0' || m2.QScores == '\0') {
                                                ^~~~
ParameterList.cpp: In member function 'void MappingOpts::setDefaults()':
ParameterList.cpp:31:9: warning: unused variable 'mismatchScoreThreshold' [-Wunused-variable]
     int mismatchScoreThreshold = -1; // No filtering by sum of mismatch score
         ^~~~~~~~~~~~~~~~~~~~~~
Genome_Index_TableQ.cpp: In member function 'unsigned int CGenome_Index_TableQ::extendAlignment(CAlignmentsQ&, CReadInBits) const':
Genome_Index_TableQ.cpp:364:10: warning: variable 'extendForward' set but not used [-Wunused-but-set-variable]
     bool extendForward = true;
          ^~~~~~~~~~~~~
In file included from ReadsQualScores.h:3:0,
                 from ReadsFileParser.h:19,
                 from ReadsFileParser.cpp:1:
In function 'char* myStrCpy(char*, const char*, int)',
    inlined from 'int CReadsFileParser::initialization()' at ReadsFileParser.cpp:28:13:
stdafx.h:184:28: warning: 'char* strncpy(char*, const char*, size_t)' writing 4095 bytes into a region of size 2048 overflows the destination [-Wstringop-overflow=]
     char* returnV = strncpy(caBuf, str, iBufSizeMinus1);
                     ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from MappingResult.cpp:1:0:
MappingResult.h: In function 'bool printAPairedMappingInPerM(FileOutputBuffer*, CMappingResult&, CMappingResult&, int, bool)':
MappingResult.h:265:26: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
         if(m1.QScores == '\0' || m2.QScores == '\0') {
                          ^~~~
MappingResult.h:265:48: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
         if(m1.QScores == '\0' || m2.QScores == '\0') {
                                                ^~~~
MappingResult.h:275:26: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
         if(m1.QScores == '\0' || m2.QScores == '\0') {
                          ^~~~
MappingResult.h:275:48: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
         if(m1.QScores == '\0' || m2.QScores == '\0') {
                                                ^~~~
makefile:26: recipe for target 'perm' failed
make[1]: *** [perm] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: make -j64 returned exit code 2
debian/rules:10: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2