[Debian-med-packaging] Bug#857424: orthanc-dicomweb: Libraries manually set in wrong order

[Tiago Stürmer Daitx]

Package: orthanc-dicomweb
Version: 0.3+dfsg-1
Severity: normal
Tags: patch

Dear Maintainer,

Similar issue as reported for orthanc-webviewer 2.2-1 in bug #857355.

Currently the file debian/patches/cmake is removing cmake's automatic
library linking resolution and adding "missing" libraries manually,
while also unecessarily modifying a link_libraries call on
Orthanc/Resources/CMake/Compiler.cmake.

The uuid library ends up being added twice while linking
libOrthancWebViewer.so. I verified that this is no longer required.

The libraries are being added through LINK_FLAGS, which is not a good
practice. On make this would be the similar to adding libraries to
LD_FLAGS instead of LD_LIBS, which causes 'undefined reference' errors
when stric order is enabled (like in Ubuntu, where the package FTBFS).

I verified that cmake is able to successfully determine the required
gdcm libraries and that the library arguments in LINK_FLAGS can be
safely removed.

Please see the attached patch for the fix.

Regards,
Tiago Daitx

-- System Information:
Debian Release: stretch/sid
  APT prefers xenial-updates
  APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500, 'xenial'), (400, 'xenial-proposed'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.8.0-34-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-library.patch
Type: text/x-diff
Size: 1872 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20170310/8fa1df99/attachment.patch>