[Debian-med-packaging] Another hdf5 issue [was: libminc has build test errors after using debhelper 10]

[Andreas Tille]

Hi Gilles,

On Fri, Nov 24, 2017 at 12:43:46AM +0100, Gilles Filippini wrote:
> Gilles Filippini a écrit le 23/11/2017 à 22:06 :
> > Hi Andreas,
> > 
> > These failures seem due mainly to the size change of type hid_t coming
> > with HDF5 1.10.0.
> > What is surprising is that nobody have encountered the issue before.
> > It's almost one full year since I first uploaded HDF5 1.10.0 to unstable
> > :/ Does this library have users actually?

I have no idea - I was just migrating this from SVN to Git and I'm
listed as Uploaders only since I once touched the package and I tend to
add myself as team uploader.

> > BTW it seems discontinued upstream: the last commit was in 2015 [1].
> > 
> > [1] https://github.com/BIC-MNI/libminc
> > 
> > I'll try to setup a patch, but I'm not sure I'll succeed, nor it's worth
> > the amount of work.
> 
> After a bit of digging, I've found this piece of code
> (libsrc/hdf_convenience.c):
> 
> MNCAPI int micreatex(const char *path, int cmode, struct mi2opts *opts_ptr)
> {
>     int fd;
> 
>     MI_SAVE_ROUTINE_NAME("micreate");
> 
>     if ((cmode & MI2_CREATE_V1) != 0) {
>         fd = nccreate(path, cmode);
>     }
>     else if (miget_cfg_bool(MICFG_FORCE_V2) || (cmode & MI2_CREATE_V2)
> != 0) {
>         fd = hdf_create(path, cmode, opts_ptr);
>     }
>     else {
>         if (mi_nc_files == 0 && mi_h5_files != 0) {
>             /* Create an HDF5 file. */
>             fd = hdf_create(path, cmode, opts_ptr);
>         }
>         else {
>             /* Create a NetCDF file. */
>             fd = nccreate(path, cmode);
>         }
>     }
>     if (fd < 0) {
>         milog_message(MI_MSG_CREATEFILE, path);
>     }
>     else {
>         char ident[128];
> 
>         micreate_ident(ident, sizeof(ident));
>         miattputstr(fd, NC_GLOBAL, "ident", ident);
>         miattputstr(fd, NC_GLOBAL, "minc_version", MINC_VERSION);
>     }
>     MI_RETURN(fd);
> }
> 
> When MICFG_FORCE_V2 or MI2_CREATE_V2 are set, the new file is created
> using hdf_create(), which should return an HDF5 file handle of type hid_t.
> But then this HDF5 file handle is passed to miattputstr() as a NetCDF
> file handle o_O. Weird. I fail to see a happy end here.
> 
> Any clue?

I do not have the slightest clue.  Steve?

Kind regards

       Andreas.

-- 
http://fam-tille.de