[Debian-med-packaging] Bug#878333: tree-puzzle: frequent parallel FTBFS

[Adrian Bunk]

Source: tree-puzzle
Version: 5.2-9
Severity: important
Tags: patch

dh compat 10 defaults to parallel building, which frequently
causes FTBFS like:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/tree-puzzle.html

...
gcc  -DHAVE_CONFIG_H -I. -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fstack-protector-strong -Wformat -Werror=format-security  -c ./gamma.c && mv gamma.o sgamma.o
...
/usr/bin/mpicc -DPARALLEL -DHAVE_CONFIG_H -I. -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fstack-protector-strong -Wformat -Werror=format-security  -c ./gamma.c && mv gamma.o pgamma.o
...
/usr/bin/mpicc -DPARALLEL -DHAVE_CONFIG_H -I. -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fstack-protector-strong -Wformat -Werror=format-security  -c ./ml2.c && mv ml2.o pml2.o
mv: cannot stat 'gamma.o': No such file or directory
Makefile:716: recipe for target 'sgamma.o' failed
make[3]: *** [sgamma.o] Error 1


That's the same intermediate file twice built and then moved.

The following works around the issue by going back to the
dh compat < 10 default of non-parallel building:

--- debian/rules.old	2017-10-12 22:02:15.000000000 +0000
+++ debian/rules	2017-10-12 22:02:31.000000000 +0000
@@ -8,7 +8,7 @@
 ppkg:=tree-ppuzzle
 
 %:
-	dh $@
+	dh $@ --no-parallel
 
 override_dh_compress:
 	dh_compress --exclude=.pdf --exclude .phy --exclude trees --exclude .b