[Debian-med-packaging] Bug#895925: libzstd FTCBFS: uses the build architecture compiler

[Helmut Grohne]

Source: libzstd
Version: 1.3.3+dfsg-1
Severity: important
Tags: patch
User: helmutg at debian.org
Usertags: rebootstrap
Control: affects -1 + src:apt

Congratulations! libzstd became part of the essential build closure as
apt started depending on it. Before too long libzstd will be on every
Debian system around.

Of course that means you get a lot more bug reports and this likely is
one of the first ones. Being part of the essential build closure is a
privilege that comes with some obligations. You need to be cross
buildable. Thus I'm filing this bug at important severity.

The actual cross build failure is rather simple and simply fixed.
dh_auto_build passes cross compilers around, so that part just works.
The later $(MAKE) invocation doesn't do that and compiles for the build
architecture instead. Replacing it with dh_auto_build makes cross
building work. I'm attaching a patch for your convenience.

Helmut
-------------- next part --------------
diff --minimal -Nru libzstd-1.3.3+dfsg/debian/changelog libzstd-1.3.3+dfsg/debian/changelog
--- libzstd-1.3.3+dfsg/debian/changelog	2017-12-21 14:25:26.000000000 +0100
+++ libzstd-1.3.3+dfsg/debian/changelog	2018-04-17 16:26:18.000000000 +0200
@@ -1,3 +1,10 @@
+libzstd (1.3.3+dfsg-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Let dh_auto_build do its work. Closes: #-1
+
+ -- Helmut Grohne <helmut at subdivi.de>  Tue, 17 Apr 2018 16:26:18 +0200
+
 libzstd (1.3.3+dfsg-1) unstable; urgency=medium
 
   * Update File-Excluded list in d/copyright
diff --minimal -Nru libzstd-1.3.3+dfsg/debian/rules libzstd-1.3.3+dfsg/debian/rules
--- libzstd-1.3.3+dfsg/debian/rules	2017-12-21 14:25:26.000000000 +0100
+++ libzstd-1.3.3+dfsg/debian/rules	2018-04-17 16:26:16.000000000 +0200
@@ -13,7 +13,7 @@
 
 override_dh_auto_build:
 	dh_auto_build
-	$(MAKE) -C contrib/pzstd/ pzstd
+	dh_auto_build --sourcedirectory=contrib/pzstd/ -- pzstd
 
 override_dh_install:
 	# Call d-shlibmove to comply with library packaging guide