[Debian-med-packaging] Bug#893526: mrs: FTBFS on 32-bit arches - error: format not a string literal and no format arguments

[Adrian Bunk]

Control: retitle -1 mrs FTBFS: error: format not a string literal and no format arguments
Control: severity -1 serious

On Mon, Mar 19, 2018 at 05:00:58PM +0000, James Cowgill wrote:
>...
> mrs FTBFS with this error on 32-bit architectures:
> >>> src/M6Parser.cpp
> > src/M6Parser.cpp: In static member function 'static M6ParserImpl* M6ParserImpl::GetObject(SV*)':
> > src/M6Parser.cpp:417:73: warning: null argument where non-null required (argument 2) [-Wnonnull]
> >    if (tmp != 0 and strcmp(kM6ScriptType, HvNAME(SvSTASH(SvRV(inScalar)))) == 0)
> >                                                                          ^
> > src/M6Parser.cpp: In function 'void _M6_Script_set_attribute(PerlInterpreter*, CV*)':
> > src/M6Parser.cpp:694:17: error: format not a string literal and no format arguments [-Werror=format-security]
> >    croak(e.what());
> >                  ^
> > src/M6Parser.cpp: In function 'void _M6_Script_set_document(PerlInterpreter*, CV*)':
> > src/M6Parser.cpp:724:17: error: format not a string literal and no format arguments [-Werror=format-security]
> >    croak(e.what());
> >                  ^
> > src/M6Parser.cpp: In function 'void _M6_Script_index_text(PerlInterpreter*, CV*)':
> > src/M6Parser.cpp:762:18: error: format not a string literal and no format arguments [-Werror=format-security]
> >     croak(e.what());
> >                   ^
> > src/M6Parser.cpp: In function 'void _M6_Script_index_string(PerlInterpreter*, CV*)':
> > src/M6Parser.cpp:802:18: error: format not a string literal and no format arguments [-Werror=format-security]
> >     croak(e.what());
> >                   ^
> > src/M6Parser.cpp: In function 'void _M6_Script_index_unique_string(PerlInterpreter*, CV*)':
> > src/M6Parser.cpp:840:18: error: format not a string literal and no format arguments [-Werror=format-security]
> >     croak(e.what());
> >                   ^
> > src/M6Parser.cpp: In function 'void _M6_Script_index_number(PerlInterpreter*, CV*)':
> > src/M6Parser.cpp:880:17: error: format not a string literal and no format arguments [-Werror=format-security]
> >    croak(e.what());
> >                  ^
> > src/M6Parser.cpp: In function 'void _M6_Script_index_date(PerlInterpreter*, CV*)':
> > src/M6Parser.cpp:918:17: error: format not a string literal and no format arguments [-Werror=format-security]
> >    croak(e.what());
> >                  ^
> > src/M6Parser.cpp: In function 'void _M6_Script_add_link(PerlInterpreter*, CV*)':
> > src/M6Parser.cpp:958:17: error: format not a string literal and no format arguments [-Werror=format-security]
> >    croak(e.what());
> >                  ^
> > cc1plus: some warnings being treated as errors
> > GNUmakefile:104: recipe for target 'obj/M6Parser.o' failed
> 
> I think the reason this only fails on 32-bit architectures is a quirk in
> the perl Configure script which I'm looking at. I don't think it's
> related to mrs (ie it _should_ have failed everywhere).

With perl 5.26.2-2 it does fail everywhere:
https://tests.reproducible-builds.org/debian/rb-pkg/buster/amd64/mrs.html

> James

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed