[Debian-med-packaging] Bug#896843: FTBFS: incorrect CPPFLAG for powerpc*

[Andreas Tille]

Hi,

On Wed, Apr 25, 2018 at 12:14:03AM +0300, Adrian Bunk wrote:
> On Tue, Apr 24, 2018 at 03:24:11PM -0500, Barry Arndt wrote:
> > Source: ctsim
> > Version: 6.0.2
> > Severity: serious
> > Tags: l10n patch
> > Justification: fails to build from source (but built successfully in the past)
> > 
> > Dear Maintainer,
> > 
> > FTBFS of ctsim-6.0.2 on ppc64el reported from unicamp.
> > 
> > The build log reported:
> > g++: error: unrecognized command line option '-faltivec'; did you mean '-maltivec'
> > 
> > The correct flag for ppc64el (as well as powerpc*) is -maltivec.
> > 
> > I changed -faltivec in configure.ac to -maltivec as follows:
> > 
> > --- ctsim-6.0.2.orig/configure.ac
> > +++ ctsim-6.0.2/configure.ac
> > @@ -137,7 +137,7 @@ case $target_cpu in
> >          CXXFLAGS="$CXXFLAGS $CPUEXT_FLAGS $SIMD_FLAGS"
> >          ;;
> >      powerpc*)
> > -        ARCH_OPTION="-fno-common -faltivec";;
> > +        ARCH_OPTION="-fno-common -maltivec";;
> >      armv1*|armv2*|armv3*|armv4*|armv5*|armv6*)
> >          ARCH_OPTION="-ffast-math";;
> >      armv7*|armv8*)
> > 
> > I then ran autoconf.  After that, the package build properly.
> 
> This whole compiler options block should be nuked,
> it also creates baseline violations on amd64 and i386.
> 
> > This fix should also fix the FTBFS of ctsim on 
> > powerpc, powerpcspe, and ppc64.
> 
> None of these have AltiVec in the port baseline,
> so that mustn't be done there.
> 
> (And ppc64el has it enabled by default, so no benefits from adding
>  -maltivec there.)

I've just uploaded a fix[1] which hopefully implements what Adrian said.

Kevin is upstream and maintainer and thus will probably include or
enhance this patch in the next release.  This mail is at the same time a
"Forward of the patch".  Kevin, please discuss here if you do not agree.
 
BTW, I have commited your recent uploads of version 6.0.x into Git.  I
have realised that you somehow silently responded to my mail about your
6.0.0-1 upload and incorporated the team changes of intermediate
uploads.  I'd be really happy if you could send some short response to
any of my mails and confirm that you use the repository on Salsa as
common Vcs for future team development.

Kind regards

        Andreas.


[1] https://salsa.debian.org/med-team/ctsim/blob/master/debian/patches/drop_incorrect_cppflags.patch
[2] https://salsa.debian.org/med-team/ctsim

-- 
http://fam-tille.de