[Debian-med-packaging] Bug#890400: physamp: autopkgtest failure

[Adrian Bunk]

Control: reassign -1 libbpp-core3 2.3.2-1
Control: reassign 890405 libbpp-core3 2.3.2-1
Control: forcemerge -1 890405
Control: retitle -1 libbpp-core3: ABI change without soname chenge
Control: affects -1 src:physamp src:maffilter

On Wed, Feb 14, 2018 at 04:08:10PM +0100, Julien Yann Dutheil wrote:
> Will do, also for maffilter.
> 
> J.
> 
> On 14 Feb 2018 13:15, "Andreas Tille" <tille at debian.org> wrote:
> 
> > Hi Graham,
> >
> > I guess Julien Dutheil will care for a patch.
> >
> > Kind regards
> >
> >        Andreas.
> >
> > On Wed, Feb 14, 2018 at 02:00:18PM +0200, Graham Inggs wrote:
> > > Source: physamp
> > > Version: 1.0.3-1
> > > Severity: serious
> > > User: ubuntu-devel at lists.ubuntu.com
> > > Usertags: origin-ubuntu bionic autopkgtest
> > >
> > > Hi Maintainer
> > >
> > > Since the upload of libbpp-core 2.3.2-1, physamp's autopkgtests have been
> > > failing [1] with the following error:
> > >
> > > autopkgtest [03:46:54]: test run-unit-test: [-----------------------
> > > bppalnoptim: symbol lookup error: bppalnoptim: undefined symbol: _
> > ZN3bpp16ApplicationTools18getDoubleParameterERKNSt7__
> > cxx1112basic_stringIcSt11char_traitsIcESaIcEEERSt3mapIS6_S6_
> > St4lessIS6_ESaISt4pairIS7_S6_EEEdS8_bi
>...

Note that there is nothing in maffilter or physamp that needs fixing,[1]
the bug is that the libbpp-core3 ABI changed without changing the soname:

src/Bpp/App/ApplicationTools.h:
     static double getDoubleParameter(
       const std::string& parameterName,
-      std::map<std::string, std::string>& params,
+      const std::map<std::string, std::string>& params,
       double defaultValue,
       const std::string& suffix = "",
       bool suffixIsOptional = true,

And a few other functions with similar changes.

In C++ this is an ABI change.

cu
Adrian

[1] a no-change rebuild would make them work again,
    but that wouldn't fix the actual problem

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed