[Debian-med-packaging] Sponsering fw4spl

[Andreas Tille]

Hi Flavien,

[switching back to public discussion which should be prefered in any case]

I had a look on fw4spl (14.0.0-1) which is in principle OK but we have
some simple lintian issues I'd love to see fixed:

DEP3: Please add the headers before I'll upload

I: fw4spl source: quilt-patch-missing-description remove_vxl_from_fwItkIO.patch
I: fw4spl source: quilt-patch-missing-description fix_glm_experimental.patch
I: fw4spl source: quilt-patch-missing-description fix_vtk6_build.patch
I: fw4spl source: quilt-patch-missing-description revert_qVTK_widget.patch


Only since you are upstream I think spelling issues should be dealt with
(not necessarily for this Debian package upload but please confirm that
you will fix it in the next upstream release):

I: fw4spl: spelling-error-in-binary usr/lib/x86_64-linux-gnu/libfwGdcmIO.so.0.1 unkown unknown
I: fw4spl: spelling-error-in-binary usr/lib/x86_64-linux-gnu/libfwGdcmIO.so.0.1 convertion conversion
I: fw4spl: spelling-error-in-binary usr/lib/x86_64-linux-gnu/libfwGui.so.0.1 Buil Build
I: fw4spl: spelling-error-in-binary usr/lib/x86_64-linux-gnu/libfwServices.so.0.1 overriden overridden
I: fw4spl: spelling-error-in-binary usr/lib/x86_64-linux-gnu/libvtkGdcmIO.so.0.1 serie series
I: fw4spl: spelling-error-in-binary usr/lib/x86_64-linux-gnu/scene2D-0.1/libscene2D-0.1.so.0.1 whitH with


May be you are not aware but you get this information via

     lintian -I --no-tag-display-limit fw4spl_14.0.0-1_amd64.changes

or even better if you set

$ grep display-info ~/.lintianrc 
display-info=yes


Other really nice things to have:

I: fw4spl source: testsuite-autopkgtest-missing
W: fw4spl: binary-without-manpage usr/bin/vrrender


In short: Please add DEP3 headers to the patches for this upload at
least and keep the other issues in mind for future uploads.

Kind regards

       Andreas.

-- 
http://fam-tille.de