[Debian-med-packaging] Bug#897864: snap: ftbfs with GCC-8

[Matthias Klose]

Package: src:snap
Version: 2013-11-29-8
Severity: normal
Tags: sid buster
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-8

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-8/g++-8, but succeeds to build with gcc-7/g++-7. The
severity of this report will be raised before the buster release.

The full build log can be found at:
http://aws-logs.debian.net/2018/05/01/gcc8/snap_2013-11-29-8_unstable_gcc8.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 8, either set CC=gcc-8 CXX=g++-8 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-8/porting_to.html

[...]
                      ^~   ~~~~
In file included from /usr/include/stdio.h:862,
                 from snap.c:31:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:33:10: note: '__builtin___sprintf_chk' output between 3 and 18 bytes into a destination of size 16
   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       __bos (__s), __fmt, __va_arg_pack ());
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
snap.c:178:22: error: '%s' directive writing up to 15 bytes into a region of size 14 [-Werror=format-overflow=]
   sprintf(option, "-N%s", name);
                      ^~   ~~~~
In file included from /usr/include/stdio.h:862,
                 from snap.c:31:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:33:10: note: '__builtin___sprintf_chk' output between 3 and 18 bytes into a destination of size 16
   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       __bos (__s), __fmt, __va_arg_pack ());
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
snap.c:185:22: error: '%s' directive writing up to 15 bytes into a region of size 14 [-Werror=format-overflow=]
   sprintf(option, "-A%s", name);
                      ^~   ~~~~
In file included from /usr/include/stdio.h:862,
                 from snap.c:31:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:33:10: note: '__builtin___sprintf_chk' output between 3 and 18 bytes into a destination of size 16
   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       __bos (__s), __fmt, __va_arg_pack ());
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
snap.c:201:23: error: '__builtin___sprintf_chk' may write a terminating nul past the end of the destination [-Werror=format-overflow=]
   sprintf(option, "-%s", name);
                       ^
In file included from /usr/include/stdio.h:862,
                 from snap.c:31:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:33:10: note: '__builtin___sprintf_chk' output between 2 and 17 bytes into a destination of size 16
   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       __bos (__s), __fmt, __va_arg_pack ());
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[4]: *** [Makefile:111: snap.o] Error 1
make[4]: Leaving directory '/<<PKGBUILDDIR>>'
make[3]: *** [Makefile:99: gcc] Error 2
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
make[2]: *** [Makefile:60: default] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: make -j8 -Oline returned exit code 2
make[1]: *** [debian/rules:24: override_dh_auto_build] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:10: build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2