[Debian-med-packaging] Bug#900196: dcmtk: wrongly assumes that CMAKE_SYSTEM_VERSION to be non-empty
Jörg Riesmeier
debian at riesmeier.de
Thu May 31 15:11:21 BST 2018
Helmut,
> While trying to make dcmtk cross buildable, I found a little bug in the
> build system. It assumes that CMAKE_SYSTEM_VERSION is non-empty. This is
> true most of the time, but CMakeDetermineSyste.cmake says:
>
> # CMAKE_SYSTEM_VERSION - on unix this is uname -r, for windows it is empty
>
> It also happens to break cross building as debhelper does not presently
> pass this variable.
thank you for the report!
> I think the best way out here would be to quote the variable to avoid
> any issues. Please consider applying the attached patch.
Instead of adding quotation marks, I would rather recommend to use the
variable name in the IF() statements and not the string value. See attached
patch (based on the current development version of the DCMTK).
I just tested it and it seems to work. What do you think?
Regards,
Joerg (for upstream)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dcmtk_cmake_system_version.patch
Type: text/x-patch
Size: 2473 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/debian-med-packaging/attachments/20180531/4be2154d/attachment.bin>
More information about the Debian-med-packaging
mailing list