[Debian-med-packaging] Bug#908459: theseus FTBFS with gcc 8

[Adrian Bunk]

Source: theseus
Version: 3.3.0-6
Severity: serious
Tags: ftbfs

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/theseus.html

...
/usr/bin/gcc -O3 -ffast-math -fstrict-aliasing -funroll-loops -fomit-frame-pointer -Wall -Werror -pedantic -std=c99 -Wno-unused-result -pthread  -c DLTutils.c
DLTutils.c: In function 'mystrncpy':
DLTutils.c:159:5: error: 'strncpy' specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
     strncpy(s1, s2, len);
     ^~~~~~~~~~~~~~~~~~~~
DLTutils.c:156:26: note: length computed here
     size_t         len = strlen(s2); /* minimum allocated length of s2 */
                          ^~~~~~~~~~
DLTutils.c: In function 'mystrcpy':
DLTutils.c:173:5: error: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]
     strncpy(s1, s2, len);
     ^~~~~~~~~~~~~~~~~~~~
DLTutils.c:171:27: note: length computed here
     size_t          len = strlen(s2);
                           ^~~~~~~~~~
In function 'mystrcpy',
    inlined from 'mystrcat' at DLTutils.c:187:5:
DLTutils.c:173:5: error: 'strncpy' specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
     strncpy(s1, s2, len);
     ^~~~~~~~~~~~~~~~~~~~
DLTutils.c: In function 'mystrcat':
DLTutils.c:171:27: note: length computed here
     size_t          len = strlen(s2);
                           ^~~~~~~~~~
In function 'mystrcpy',
    inlined from 'GetUniqFileNameNum' at DLTutils.c:323:5:
DLTutils.c:173:5: error: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]
     strncpy(s1, s2, len);
     ^~~~~~~~~~~~~~~~~~~~
DLTutils.c: In function 'GetUniqFileNameNum':
DLTutils.c:171:27: note: length computed here
     size_t          len = strlen(s2);
                           ^~~~~~~~~~
In function 'mystrcpy',
    inlined from 'GetUniqFileNameNum' at DLTutils.c:323:5,
    inlined from 'myfopen' at DLTutils.c:342:5:
DLTutils.c:173:5: error: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]
     strncpy(s1, s2, len);
     ^~~~~~~~~~~~~~~~~~~~
DLTutils.c: In function 'myfopen':
DLTutils.c:171:27: note: length computed here
     size_t          len = strlen(s2);
                           ^~~~~~~~~~
In function 'mystrncpy',
    inlined from 'getroot' at DLTutils.c:560:5:
DLTutils.c:159:5: error: 'strncpy' specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
     strncpy(s1, s2, len);
     ^~~~~~~~~~~~~~~~~~~~
DLTutils.c: In function 'getroot':
DLTutils.c:556:30: note: length computed here
     int             length = strlen(filename);
                              ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[3]: *** [Makefile:10: DLTutils.o] Error 1