[Debian-med-packaging] Bug#908456: invesalius is no longer installable

[Thiago Franco de Moraes]

On Tue, Sep 11, 2018 at 1:49 PM Andreas Tille <andreas at fam-tille.de> wrote:
>
> Hi Thiago,
>
> On Tue, Sep 11, 2018 at 10:21:51AM -0300, Thiago Franco de Moraes wrote:
> > Hi Andreas,
> >
> > Done! I've just pulled the changes to Salsa. I created a new release (3.1.99992).
>
> Good. :-)
>
> > But I'm getting this warning:
> >  dpkg-gencontrol: warning: Depends field of package invesalius: unknown substitution variable ${python:Depends}
>
> This was easy - see my latest commit.

Thanks!

> > This warning happens with both my last version and with the last change you did. I'm using "gbp buildpackage" to create the package in Ubuntu and Debian Sid. I tested the package in Debian Sid and it is working correctly.
>
> Hmmm, here is a less easy one - no idea why you do not get this.  There
> are some remaining Python2 scripts that need to be ported:
>
> E: invesalius: missing-dep-for-interpreter python2 => python:any | python-minimal:any | python2:any | python2-minimal:any (usr/share/invesalius/invesalius/data/viewer_slice.py) #!/usr/bin/python2
> N:
> N:    You used an interpreter for a script that is not in an essential
> N:    package. In most cases, you will need to add a Dependency on the package
> N:    that contains the interpreter. If the dependency is already present,
> N:    please file a bug against Lintian with the details of your package so
> N:    that its database can be updated.
> N:  
> N:    In some cases a weaker relationship, such as Suggests or Recommends,
> N:    will be more appropriate.
> N:  
> N:    Severity: important, Certainty: possible
> N:  
> N:    Check: scripts, Type: binary
> N:
> E: invesalius: missing-dep-for-interpreter python2 => python:any | python-minimal:any | python2:any | python2-minimal:any (usr/share/invesalius/invesalius/data/viewer_volume.py) #!/usr/bin/python2
> E: invesalius: missing-dep-for-interpreter python2 => python:any | python-minimal:any | python2:any | python2-minimal:any (usr/share/invesalius/invesalius/gui/widgets/gradient.py) #!/usr/bin/python2

I created a patch to remove the python2 shebangs. This patch was already applied into the upstream. But there is other problem:

W: invesalius: executable-not-elf-or-script usr/share/invesalius/invesalius/gui/widgets/gradient.py
W: invesalius: executable-not-elf-or-script usr/share/invesalius/invesalius/data/viewer_slice.py
W: invesalius: executable-not-elf-or-script usr/share/invesalius/invesalius/data/viewer_volume.py

This is happening because these files have execution permission:

▶ find -executable -type f -name "*.py"
./invesalius/data/viewer_slice.py
./invesalius/data/viewer_volume.py
./invesalius/gui/widgets/gradient.py

This is a problem at the upstream. I don't know why this happened, maybe someone using Windows ... I already fixed this problem at the upstream. But I don't know how to solve this problem in the packaging.

There is other problem, but I already fixed. I used debuild to test a change in the packaging that I did. It worked but when I commit the change I also commit some changes in the source code of InVesalius. I think debuild didn't unapply the patches. This happened at the commit 83d10824. I fixed this problem at the commit 0a1dfc00. Using the git diff to see the differences between the head and the upstream/3.1.99992 show the only difference are the debian folder:

git diff --name-only HEAD upstream/3.1.99992
debian/changelog
debian/compat
debian/control
debian/copyright
debian/dirs
debian/docs
debian/invesalius-bin.install
debian/invesalius-examples.examples
debian/invesalius.desktop
debian/invesalius.install
debian/invesalius.lintian-overrides
debian/invesalius.manpages
debian/invesalius.xpm
debian/invesalius3.1
debian/links
debian/patches/10_import_cython_modules.patch
debian/patches/10_remove_python2_shebang.patch
debian/patches/10_sample_path.patch
debian/patches/series
debian/rules
debian/source/format
debian/source/options
debian/watch
(END)

So I think this is fixed.

> Kind regards
>
>       Andreas.
>
> --
> http://fam-tille.de

Best regards