[Debian-med-packaging] Bug#935579: cwltool: bad upstream test testing udocker, not cwltool

[Steve Langasek]

Package: cwltool
Version: 1.0.20181217162649+dfsg-10
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu eoan ubuntu-patch

Hi Michael,

Since the introduction of cwltool 1.0.20181217162649+dfsg-1, the cwltool
autopkgtests in Ubuntu have been failing on all architectures except for
amd64.  The reason for this is that upstream has added tests for the
handling of udocker, a third-party tool which is downloaded from the
Internet during the test and which is not properly ported to non-x86
architectures.

I don't think this is a useful test to have as an autopkgtest generally,
because it's dependent on the behavior of a third-party resource downloaded
from the network whose behavior may change over time (at minimum, the
resource might go away).  And since it has caused autopkgtests to regress on
all non-amd64 architectures in Ubuntu, I've uploaded the attached patch to
Ubuntu to suppress the udocker tests.

Unfortunately, in the meantime it appears that some other change has caused
cwltool to FTBFS in both Debian and Ubuntu.  But in any case, please
consider including this change in your next upload.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru cwltool-1.0.20181217162649+dfsg/debian/patches/no-udocker.patch cwltool-1.0.20181217162649+dfsg/debian/patches/no-udocker.patch
--- cwltool-1.0.20181217162649+dfsg/debian/patches/no-udocker.patch	1969-12-31 16:00:00.000000000 -0800
+++ cwltool-1.0.20181217162649+dfsg/debian/patches/no-udocker.patch	2019-08-23 23:49:08.000000000 -0700
@@ -0,0 +1,38 @@
+Description: don't run udocker tests
+ These tests are not testing cwltool, they're testing a third-party
+ udocker tool which is non-portable and whose behavior may change over time.
+Author: Steve Langasek <steve.langasek at ubuntu.com>
+Last-Modified: 2019-08-23
+
+Index: cwltool-1.0.20181217162649+dfsg/tests/test_udocker.py
+===================================================================
+--- cwltool-1.0.20181217162649+dfsg.orig/tests/test_udocker.py
++++ cwltool-1.0.20181217162649+dfsg/tests/test_udocker.py
+@@ -16,6 +16,7 @@
+ 
+     @classmethod
+     def setup_class(cls):
++        return True
+         install_cmds = [
+             "curl https://raw.githubusercontent.com/indigo-dc/udocker/master/udocker.py -o ./udocker",
+             "chmod u+rx ./udocker",
+@@ -36,9 +37,11 @@
+ 
+     @classmethod
+     def teardown_class(cls):
++        return True
+         shutil.rmtree(cls.docker_install_dir)
+ 
+     def test_udocker_usage_should_not_write_cid_file(self, tmpdir):
++        return True
+         cwd = tmpdir.chdir()
+ 
+         test_file = "tests/wf/wc-tool.cwl"
+@@ -56,6 +59,7 @@
+ 
+     @pytest.mark.skipif(TRAVIS, reason='Not reliable on single threaded test on travis.')
+     def test_udocker_should_display_memory_usage(self, tmpdir):
++        return True
+         cwd = tmpdir.chdir()
+         error_code, stdout, stderr = get_main_output(
+             ["--enable-ext", "--default-container=debian",  "--user-space-docker-cmd=" + self.udocker_path,
diff -Nru cwltool-1.0.20181217162649+dfsg/debian/patches/series cwltool-1.0.20181217162649+dfsg/debian/patches/series
--- cwltool-1.0.20181217162649+dfsg/debian/patches/series	2018-12-23 15:17:57.000000000 -0800
+++ cwltool-1.0.20181217162649+dfsg/debian/patches/series	2019-08-23 23:49:15.000000000 -0700
@@ -8,3 +8,4 @@
 spelling
 cleanup-tests
 python3
+no-udocker.patch